-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a checkbox to show or hide the word "Specialization" for the "Talents" module #160
Comments
Before displaying the specialization there will be displayed "Specialization: Loading..." a short time before the asynchronous inspect request is ready. If the unit is out of inspection range (in WotLKC or Classic Era it's significantly shorter than in Retail/Dragonflight) there will be shown "Specialization: Out of range". If "Specialization:" in this cases would be removed, you don't know with the remaining "Loading..." or "Out of range" what kind of information this relates to. Perhaps with the mentioned checkbox the "Specialization:" will only be hidden when the specialization is ready to display. Or the "Specialization: Loading..." and "Specialization: Out of range" will also be suppressed. What do you think? |
Yeah it seems in the fail case you could display something like “Spec:
Unknown” or “Spec: Out of range”. But in the positive case when we have the
target spec, the prefix string isn’t giving me any valuable info. But,
great point on those fail cases. I totally overlooked them.
…On Mon, Dec 26, 2022 at 3:20 AM frozn ***@***.***> wrote:
Before displaying the specialization there will be displayed
"Specialization: Loading..." a short time before the asynchronous inspect
request is ready. If the unit is out of inspection range (in WotLKC or
Classic Era it's significantly shorter than in Retail/Dragonflight) there
will be shown "Specialization: Out of range". If "Specialization:" in this
cases would be removed, you don't know with the remaining "Loading..." or
"Out of range" what kind of information this relates to.
Perhaps with the mentioned checkbox the "Specialization:" will only be
hidden when the specialization is ready to display. Or the "Specialization:
Loading..." and "Specialization: Out of range" will also be suppressed.
What do you think?
—
Reply to this email directly, view it on GitHub
<#160 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEI2CVSCW7OJSOND237IGDWPF5OJANCNFSM6AAAAAATFCKCBU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
fwiw i hacked the lua and omitted the prefix and didn’t even notice those
fail cases yet.
…On Mon, Dec 26, 2022 at 8:50 AM Dak ***@***.***> wrote:
Yeah it seems in the fail case you could display something like “Spec:
Unknown” or “Spec: Out of range”. But in the positive case when we have the
target spec, the prefix string isn’t giving me any valuable info. But,
great point on those fail cases. I totally overlooked them.
On Mon, Dec 26, 2022 at 3:20 AM frozn ***@***.***> wrote:
> Before displaying the specialization there will be displayed
> "Specialization: Loading..." a short time before the asynchronous inspect
> request is ready. If the unit is out of inspection range (in WotLKC or
> Classic Era it's significantly shorter than in Retail/Dragonflight) there
> will be shown "Specialization: Out of range". If "Specialization:" in this
> cases would be removed, you don't know with the remaining "Loading..." or
> "Out of range" what kind of information this relates to.
>
> Perhaps with the mentioned checkbox the "Specialization:" will only be
> hidden when the specialization is ready to display. Or the "Specialization:
> Loading..." and "Specialization: Out of range" will also be suppressed.
>
> What do you think?
>
> —
> Reply to this email directly, view it on GitHub
> <#160 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABEI2CVSCW7OJSOND237IGDWPF5OJANCNFSM6AAAAAATFCKCBU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Is your feature request related to a problem? Please describe.
When mousing over a player, the Talents line reads, "Specialization: <target's Spec>". I really don't need the word "specialization" there. It's redundant bloat.
Describe the solution you'd like
Remove the string or add a checkbox in the Talens tab in TipTac Options to show / hide this string.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: