Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for rubyzip 1.0.0 #28

Merged
merged 1 commit into from
Oct 29, 2013
Merged

updated for rubyzip 1.0.0 #28

merged 1 commit into from
Oct 29, 2013

Conversation

mreinsch
Copy link
Contributor

@mreinsch mreinsch commented Oct 2, 2013

With the release of rubyzip 1.0, some class names changed. This addresses those changes.

lgleasain added a commit that referenced this pull request Oct 29, 2013
@lgleasain lgleasain merged commit 6ff11e3 into frozon:master Oct 29, 2013
@george-carlin
Copy link

I've updated my Gemfile to pull the latest version of this gem and I now get this error on Heroku (but not locally): uninitialized constant Zip::OutputStream:

@lgleasain
Copy link
Collaborator

Try pulling the latest version of the passbook gem..... 3.1

@george-carlin
Copy link

FINALLY figured this out.

When I ran ruby app.rb, everything worked fine, but when I ran bundle exec ruby app.rb (i.e. I ran using the exact same Gem versions that heroku would use) it didn't. I updated passbook, but things still didn't work. Turns out I needed to remove gem 'zip' from my Gemfile and just include gem 'rubyzip'.

I've tried so many changes in the last hour I can't say with certainty that gem 'zip' was the sole cause of the problem, but removing it was the final step that made everything work.

@lgleasain
Copy link
Collaborator

cool.....it was beginning to sound like that....we needed to update the rubyzip anyways, so that was a good excuse to get that done :). Let me know if you have any other problems etc....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants