Skip to content

Commit

Permalink
isisd: circuit is derefed in every code path
Browse files Browse the repository at this point in the history
No need to check for circuit being null, we have
already de-refed it in every code path and
would have crashed before this point if it was.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
  • Loading branch information
donaldsharp committed Sep 25, 2019
1 parent 8396ec6 commit b53c5f1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions isisd/isis_te.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ void isis_link_params_update(struct isis_circuit *circuit,
return;

/* Sanity Check */
if ((circuit == NULL) || (ifp == NULL)
|| (circuit->state != C_STATE_UP))
if ((ifp == NULL) || (circuit->state != C_STATE_UP))
return;

zlog_debug("TE(%s): Update circuit parameters for interface %s",
Expand Down

0 comments on commit b53c5f1

Please sign in to comment.