Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed php code sample #1

Closed
wants to merge 1 commit into from
Closed

fixed php code sample #1

wants to merge 1 commit into from

Conversation

staabm
Copy link

@staabm staabm commented Nov 20, 2015

the code sample at the page has a opacity of 0.5, which makes it hard to read.
I dont know exactly where it comes from, but I guess the php-starting tag, which is not present in the other php code snippets could be the reason

see the greyed shadow over the "Reading XML" Code box
http://i.imgur.com/GsadATy.png

@staabm
Copy link
Author

staabm commented Nov 20, 2015

beware: this change is untested

@Hywan
Copy link
Collaborator

Hywan commented Nov 20, 2015

Sounds good to me. Can you squash your commits please?

@staabm
Copy link
Author

staabm commented Nov 20, 2015

@Hywan still untested but squashed ;)

@evert
Copy link
Member

evert commented Nov 20, 2015

Hey! This is not the right place to create PR's.

This repository is basically completely managed by a script. We use it to take advantage of github pages, but it's not intended as the source repository for the website.

So any changes really have to be made here:

https://github.com/fruux/sabre.io/tree/master/source

Because if not, the next time I deploy everything will be overwritten

@staabm
Copy link
Author

staabm commented Nov 20, 2015

@evert sry will move the commits on monday

@evert
Copy link
Member

evert commented Nov 20, 2015

No problem, and you'll probably find it becomes a LOT easier to make changes there anyway ;)

@evert evert closed this Nov 20, 2015
staabm referenced this pull request in sabre-io/sabre.io Nov 20, 2015
@staabm staabm deleted the patch-1 branch November 23, 2015 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants