Create basic Relics page #2025

tiffanynwyeung · 2024-04-26T23:09:50Z

Describe your changes

Generate Relics page lib
Move Relic-related components to specific page
Standardize styling across Relics and Light Cones pages (in-depth explanation: make it look more like the GO pages by wrapping things in CardThemed and removing Container components because it's rendering the site UI smaller than usual with Container wrapped around it)
remove useTranslation hook being improperly called in sort/filter configs from last PR

Issue or discord link

Resolves #1995

Testing/validation

Relics page (note: this was screenshotted with browser zoomed out b/c currently on smaller screen resolution)

Light Cone page

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

I have commented my code in hard-to understand areas.
I have made corresponding changes to README or wiki.
For front-end changes, I have updated the corresponding English translations.
I have run yarn run mini-ci locally to validate format and lint.
If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

github-actions · 2024-04-26T23:12:47Z

[frontend] [Fri Apr 26 23:12:46 UTC 2024] - Deployed f7a9ea3 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Apr 26 23:13:22 UTC 2024] - Deployed 958d4f3 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Fri Apr 26 23:13:37 UTC 2024] - Deployed 958d4f3 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Fri Apr 26 23:13:58 UTC 2024] - Deployed f7a9ea3 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Apr 30 00:50:11 UTC 2024] - Deployed eff835b to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Apr 30 00:51:03 UTC 2024] - Deployed eff835b to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Apr 30 01:07:34 UTC 2024] - Deployed 1e74aaa to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Apr 30 01:08:10 UTC 2024] - Deployed 1e74aaa to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Apr 30 01:40:45 UTC 2024] - Deployed df8a9e4 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Apr 30 01:42:18 UTC 2024] - Deployed df8a9e4 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Apr 30 01:43:10 UTC 2024] - Deployed 0b42a24 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Apr 30 01:47:29 UTC 2024] - Deployed 0b42a24 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Apr 30 02:49:49 UTC 2024] - Deployed 285f833 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Apr 30 02:50:16 UTC 2024] - Deployed 285f833 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Apr 30 03:22:48 UTC 2024] - Deployed 00d03db to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Apr 30 03:23:26 UTC 2024] - Deployed 00d03db to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Tue Apr 30 04:23:58 UTC 2024] - Deployed 4c2c909 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue Apr 30 04:24:27 UTC 2024] - Deployed 4c2c909 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Thu May 2 06:22:39 UTC 2024] - Deployed 83ff875 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 2 06:23:04 UTC 2024] - Deployed 83ff875 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Thu May 2 06:23:48 UTC 2024] - Deployed 0d39ba7 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 2 06:23:53 UTC 2024] - Deployed 0d39ba7 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Thu May 2 06:33:34 UTC 2024] - Deployed 51613ba to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 2 06:34:23 UTC 2024] - Deployed 51613ba to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Thu May 2 06:35:33 UTC 2024] - Deployed 202c4e2 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 2 06:35:35 UTC 2024] - Deployed 202c4e2 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Thu May 2 07:10:32 UTC 2024] - Deployed 8ff5169 to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 2 07:10:46 UTC 2024] - Deployed 8ff5169 to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu May 2 17:14:22 UTC 2024] - Deployed 9f603bc to https://genshin-optimizer-prs.github.io/pr/2025/frontend (Takes 3-5 minutes after this completes to be available)

[sr-frontend] [Thu May 2 17:15:08 UTC 2024] - Deployed 9f603bc to https://genshin-optimizer-prs.github.io/pr/2025/sr-frontend (Takes 3-5 minutes after this completes to be available)

[Thu May 2 17:55:12 UTC 2024] - Deleted deployment

frzyc

Some editorial comments, and one request change.

apps/sr-frontend/src/app/Header.tsx

libs/sr/page-relics/project.json

frzyc · 2024-04-28T19:53:58Z

libs/sr/ui/src/LightCone/LightConeEditor/LightConeEditor.tsx

@@ -124,7 +123,7 @@ export function LightConeEditor({
  }, [lightConeIdToEdit])

  return (
-    <Container>
+    <Suspense fallback={false}>


Probably a good idea to put something in here, since using fallback=false would cause layout shift as element is loaded. I am fine leaving this here for now since we are likely to put this element in a modal later.

Agreed on the last point, I was expecting to have both of the editors be contained in modals later and I was using this opportunity with the PR to align the SRO styling to be consistent with GO.

libs/sr/ui/src/Relic/RelicInventory.tsx

libs/sr/util/src/lightcone.ts

frzyc

Remove the 2 extra useMemo and we should be good.

apps/sr-frontend/src/app/Header.tsx

removed useTranslation calls in sort/filter configs because it breaks react hooks rules (whoops) once i18n gets implemented for SRO, will have to update strings to call i18n to safely translate names properly also, update comments to follow standard styling

frzyc

LGTM

tiffanynwyeung force-pushed the sro/create-relics-page branch from 11c5ccd to 53887a9 Compare April 26, 2024 23:10

frzyc requested changes Apr 28, 2024

View reviewed changes

tiffanynwyeung force-pushed the sro/create-relics-page branch 5 times, most recently from a4f9313 to add1a26 Compare April 30, 2024 03:20

frzyc mentioned this pull request Apr 30, 2024

Tally should update on add/remove, not all events #2051

Open

tiffanynwyeung added 3 commits May 1, 2024 23:21

generate relics page lib, move relic components to page

f2d6736

standardize styling across pages

09211a1

remove unnecessary lint targets from project.json for both pages

cc89601

tiffanynwyeung force-pushed the sro/create-relics-page branch from 449cfda to 6e26222 Compare May 2, 2024 06:21

tiffanynwyeung requested a review from frzyc May 2, 2024 06:24

frzyc requested changes May 2, 2024

View reviewed changes

libs/sr/ui/src/Relic/RelicInventory.tsx Outdated Show resolved Hide resolved

libs/sr/ui/src/Relic/RelicInventory.tsx Outdated Show resolved Hide resolved

libs/sr/util/src/lightcone.ts Outdated Show resolved Hide resolved

tiffanynwyeung force-pushed the sro/create-relics-page branch 2 times, most recently from 89af094 to 82b15e2 Compare May 2, 2024 06:32

tiffanynwyeung requested a review from frzyc May 2, 2024 07:17

frzyc requested changes May 2, 2024

View reviewed changes

apps/sr-frontend/src/app/Header.tsx Outdated Show resolved Hide resolved

apps/sr-frontend/src/app/Header.tsx Outdated Show resolved Hide resolved

tiffanynwyeung force-pushed the sro/create-relics-page branch from 3d3c164 to 1e1d371 Compare May 2, 2024 17:11

tiffanynwyeung requested a review from frzyc May 2, 2024 17:47

frzyc approved these changes May 2, 2024

View reviewed changes

frzyc merged commit 4f66f13 into frzyc:master May 2, 2024
7 checks passed

tiffanynwyeung deleted the sro/create-relics-page branch May 2, 2024 18:17

tiffanynwyeung mentioned this pull request May 2, 2024

Update SRO Header totals to change only on add/remove #2061

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create basic Relics page #2025

Create basic Relics page #2025

tiffanynwyeung commented Apr 26, 2024 •

edited

github-actions bot commented Apr 26, 2024 •

edited

frzyc left a comment

frzyc Apr 28, 2024

tiffanynwyeung Apr 30, 2024

frzyc left a comment

frzyc left a comment

Create basic Relics page #2025

Create basic Relics page #2025

Conversation

tiffanynwyeung commented Apr 26, 2024 • edited

Describe your changes

Issue or discord link

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

github-actions bot commented Apr 26, 2024 • edited

frzyc left a comment

Choose a reason for hiding this comment

frzyc Apr 28, 2024

Choose a reason for hiding this comment

tiffanynwyeung Apr 30, 2024

Choose a reason for hiding this comment

frzyc left a comment

Choose a reason for hiding this comment

frzyc left a comment

Choose a reason for hiding this comment

tiffanynwyeung commented Apr 26, 2024 •

edited

github-actions bot commented Apr 26, 2024 •

edited