Require basic auth if ENV["AUTH_BASIC_PASS"] is set #302
Conversation
|
@ruslankhaertdinov could you please add note to the CHANGELOG and README? |
|
@timurvafin sure |
|
@timurvafin done |
| @@ -2,13 +2,14 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ## 1.3 - 2015-07-03 | |||
| ## 1.3 - 2015-07-27 | |||
There was a problem hiding this comment.
@ruslankhaertdinov no need to change release date here, just add your new line in the "Unreleased" section.
|
@timurvafin Let ENV vars with description be in the separate PR. |
|
@timurvafin ENV vars described in this PR: #304 |
| @@ -9,6 +9,7 @@ | |||
| - Fix `rails_best_practices` invocation from `bin/quality`, `config/rails_best_practices.yml` was ignored before. | |||
| - Introduce [CSSComb](https://github.com/csscomb/csscomb.js). For more details see: https://github.com/fs/rails-base/pull/284 | |||
| - Add `Brewfile` to track application dependencies. | |||
| - Add ability to close app from unauthorized viewers, see: https://github.com/fs/rails-base/pull/302/files | |||
There was a problem hiding this comment.
please add it to "Unreleased" section. Time travel is prohibited on our planet.
There was a problem hiding this comment.
It's my mistake
|
@vast done |
|
@ruslankhaertdinov #304 was merged in to After that please cleanup commits and we will be ready to merge. Thanks |
ruslankhaertdinov
force-pushed
the
basic-auth-299
branch
from
1d9ad71
to
97c3043
Compare
|
@timurvafin I already rebase this branch with master (and squash commits), should I do anything else? |
timurvafin
changed the title
|
Can't merge this branch b/c of conflicts |
ruslankhaertdinov
force-pushed
the
basic-auth-299
branch
from
97c3043
to
dbc5d52
Compare
|
@timurvafin I fix conflicts |
Require basic auth if ENV["AUTH_BASIC_PASS"] is set
Related to: #299