Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML code quality #22

Merged
merged 7 commits into from
Jan 15, 2014
Merged

HTML code quality #22

merged 7 commits into from
Jan 15, 2014

Conversation

vast
Copy link
Contributor

@vast vast commented Jan 14, 2014

  • removed messy conditional comments since we support IE8+ (and it doesn't always require CSS fixes)
  • fixed google_analytics_tag in development
  • updated jquery version to 1.10.2
  • removed empty meta[name=description]
  • set initial scale as 1 in viewport meta tag
  • fixed url for html5shiv

@timurvafin
Copy link
Member

@vast what you think if we will replace current markup with simple bootstrap template?
And isn't it better to include query with rails-assets?

timurvafin added a commit that referenced this pull request Jan 15, 2014
@timurvafin timurvafin merged commit 9ab9d19 into master Jan 15, 2014
@timurvafin timurvafin deleted the html-code-quality branch January 15, 2014 13:40
@vast
Copy link
Contributor Author

vast commented Jan 15, 2014

@timurvafin, sorry for taking so long to reply.

I'm going to work on JS issues in another PR. Sure, will look for a better jQuery approach.

As for the bootstrap template, I'm not sure that we can choose one proper version at this moment. There is 3.0.3 version which is not so stable (and some people simply switch back to 2.3.2) and good old 2.3.2 which is consistent and well-tested.

I'd suggest using bootstrap after bootstrap 3.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants