FEAT: add 'NonWhiteSpaceString' to the default generated types #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we also have a `String.IsNullOrWhiteSpace` and this is used quite a lot for guard assertions and validations; it seems logical to also generate strings without whitespace characters.
|
I agree! Although, when deserializing to domain models and validating them; they sometimes could be seen as "the same". |
No, I'll let @kurtschelfthout make that decision. I now realise that my comment was insensitive. I apologise 😳 |
No problem ;) |
|
I think it’s a reasonable addition, and largely independent of the value or evilness :) of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we also have a
String.IsNullOrWhiteSpaceand this is used quitea lot for guard assertions and validations; it seems logical to also
generate strings without whitespace characters.
Seems reasonable?
Thanks.