Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release #665

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Fix release #665

merged 1 commit into from
Feb 25, 2024

Conversation

Smaug123
Copy link
Contributor

@Smaug123 Smaug123 commented Feb 25, 2024 •
edited
Loading

The bug was not setting a user-agent, but this way we are also more explicit if things go wrong.

Requests with no User-Agent header will be rejected. If you provide an invalid User-Agent header, you will receive a 403 Forbidden response.
(https://docs.github.com/en/rest/using-the-rest-api/getting-started-with-the-rest-api?apiVersion=2022-11-28#user-agent)

@Smaug123 Smaug123 mentioned this pull request Feb 25, 2024
Closed
7 tasks
Smaug123
Smaug123 commented Feb 25, 2024
View reviewed changes
build.fsx
@@ -530,7 +530,7 @@ type GitHubReleaseResponse =
[<JsonPropertyName "name">]
Name : string
[<JsonPropertyName "published_at">]
PublishedAt : DateTime
PublishedAt : System.Nullable<DateTime>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I observed this to be null in my testing)

@kurtschelfthout kurtschelfthout merged commit 2b76d35 into fscheck:master Feb 25, 2024
1 check passed
@Smaug123 Smaug123 deleted the fix-release branch February 25, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Smaug123 @kurtschelfthout