Switch auth system to cancan WIP #69

henrikssn · 2015-03-19T12:19:32Z

This PR will migrate the code base from TheRole to cancancan.

Solves #67 and needs #68

Note: Work in progress, help is very welcome!

houndci-bot · 2015-03-19T12:19:36Z

app/models/ability.rb

+class Ability
+  include CanCan::Ability
+
+  def initialize(user)


Unused method argument - user. If it's necessary, use _ or _user as an argument name to indicate that it won't be used. You can also write as initialize(*) if you want the method to accept any arguments but don't care about them.

davidwessman · 2015-03-19T15:44:53Z

How will we give a user permissions? Can it be done depending on their Post?
Or what did you have in mind? @henrikssn @jforberg @lham

henrikssn · 2015-03-19T16:02:34Z

@Zofz My proposal:

model Permission
  has_and_belongs_to_many :posts
  :subject_class # model names like User, Role, Book, Author
  :action        # controller action like new, create or destroy
model Post
  has_and_belongs_to_many :permissions

Then do something like
http://blog.joshsoftware.com/2012/10/23/dynamic-roles-and-permissions-using-cancan/

jforberg · 2015-03-19T23:13:00Z

Jag gillar @henrikssn lösning. Bättre att jobba på normalformen än att knacka in JSON-strängar i sin databas. JSONkolumner luktar lite som att man inte riktigt har koll på hur databaser funkar.

Dock skulle jag inte använda HABTM. Jag vet att det lärs ut fortfarande men det är inte bra av två skäl:

HABTM stödjer inte valideringar, därför att
HABTM är databasinkontinent, den committar alltid omedelbart. Vilket oftast inte är vad man vill

has_many :through => är ett bättre alternativ ~~i de flesta fall~~ alltid.

davidwessman · 2015-03-20T23:45:50Z

Implementing more tests in #87

houndci-bot · 2015-03-21T14:03:11Z

app/controllers/admin/elections_controller.rb

@@ -61,7 +61,7 @@ def candidates
  end
  private
  def authenticate
-    flash[:error] = t('the_role.access_denied')
+


Trailing whitespace detected.

houndci-bot · 2015-03-21T14:42:43Z

app/controllers/application_controller.rb

  protect_from_forgery

  before_filter :configure_permitted_devise_parameters, if: :devise_controller?
  before_filter :set_locale
  before_filter :get_commit

+  rescue_from CanCan::AccessDenied do |ex|
+    flash[:error] = ex.message
+    render :text => '', :layout => true, :status => :forbidden


Use the new Ruby 1.9 hash syntax.

Conflicts: Gemfile Gemfile.lock app/controllers/application_controller.rb app/controllers/events_controller.rb app/controllers/posts_controller.rb app/controllers/static_pages_controller.rb app/views/layouts/_topbar.html.erb app/views/layouts/_utskottmenu.html.erb app/views/posts/_post.html.erb config/routes.rb db/schema.rb

houndci-bot · 2015-03-26T13:26:45Z

app/controllers/events_controller.rb

@@ -101,12 +100,24 @@ def destroy

  private
  def authenticate
+<<<<<<< HEAD


unexpected token tLSHFT

houndci-bot · 2015-03-26T13:28:36Z

app/controllers/posts_controller.rb

  before_action :set_post, only: [:show, :edit, :update, :destroy, :remove_profile,:add_profile_username, :display]

  def remove_profile
    @profile = Profile.find_by_id(params[:profile_id])
    @post.profiles.delete(@profile)    
    respond_to do |format|
-    format.html { redirect_to council_posts_path(@council), notice: @profile.name.to_s + ' har inte längre posten ' + @post.title.to_s + '.'}
+      format.html { redirect_to council_posts_path(@council), notice: @profile.name.to_s + ' har inte längre posten ' + @post.title.to_s + '.'}


Line is too long. [143/100]
Space missing inside }.

henrikssn · 2015-03-26T13:41:08Z

@fsek/admins Will merge this later today or tomorrow. Please take a look.

…ssion

jforberg · 2015-03-26T14:41:54Z

Looks like great work @henrikssn

houndci-bot · 2015-03-26T15:11:48Z

app/controllers/councils_controller.rb

-      rescue ActionController::RedirectBackError
-      redirect_to root_path
+
+    def set_councils


Inconsistent indentation detected.

henrikssn · 2015-03-26T15:28:26Z

Merging when test results arrive...

Switch auth system to cancan WIP

henrikssn · 2015-03-26T15:37:37Z

Fingers crossed 👌

ghost · 2015-03-26T15:58:39Z

This PR was deployed to Production. Reference: 86e473e

davidwessman · 2015-03-26T16:47:33Z

👍

henrikssn added 3 commits March 19, 2015 13:12

Remove the_role and add cancancan as dep

4432b07

Remove some mentions of TheRole

4783ae8

Add cancan ability model

111c219

houndci-bot reviewed Mar 19, 2015
View reviewed changes

henrikssn mentioned this pull request Mar 19, 2015

Controller tests #70

Merged

davidwessman mentioned this pull request Mar 20, 2015

HABTM > has_many, through #76

Closed

jforberg added 2 commits March 21, 2015 15:02

Remove references to the_role in code.

ddf8018

Handle access errors centrally in appcontroller.

f6c9b52

houndci-bot reviewed Mar 21, 2015
View reviewed changes

henrikssn and others added 4 commits March 21, 2015 15:40

Replace current_user.moderator with can? in views

a97af7a

Add pry so we can debug code.

172e63c

Port the news controller to cancan.

243f4a1

Merge branch 'cancan' of github.com:fsek/web into cancan

64be0c8

houndci-bot reviewed Mar 21, 2015
View reviewed changes

houndci-bot reviewed Mar 26, 2015
View reviewed changes

app/controllers/events_controller.rb

@@ -101,12 +100,24 @@ def destroy

private

def authenticate

<<<<<<< HEAD

Copy link

houndci-bot Mar 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected token tLSHFT

Missed a merge conflict

b3be67d

houndci-bot reviewed Mar 26, 2015
View reviewed changes

All tests pass, ready to merge

72032e4

henrikssn and others added 3 commits March 26, 2015 14:55

Test config

0a4720d

Forgot two files

0110d26

Removed some old things in seeds.rb, changed validate-syntax in Permi…

47eb1a5

…ssion

henrikssn added 2 commits March 26, 2015 16:11

Fix post edit

ff7ff47

Merge branch 'cancan' of github.com:fsek/web into cancan

ff9cc73

houndci-bot reviewed Mar 26, 2015
View reviewed changes

Hound fixes

ee8fdb4

henrikssn added a commit that referenced this pull request Mar 26, 2015

Merge pull request #69 from fsek/cancan

86e473e

Switch auth system to cancan WIP

henrikssn merged commit 86e473e into master Mar 26, 2015

davidwessman added the resolved/fixed label Mar 26, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch auth system to cancan WIP #69

Switch auth system to cancan WIP #69

henrikssn commented Mar 19, 2015

houndci-bot Mar 19, 2015

davidwessman commented Mar 19, 2015

henrikssn commented Mar 19, 2015

jforberg commented Mar 19, 2015

davidwessman commented Mar 20, 2015

houndci-bot Mar 21, 2015

houndci-bot Mar 21, 2015

houndci-bot Mar 26, 2015

houndci-bot Mar 26, 2015

henrikssn commented Mar 26, 2015

jforberg commented Mar 26, 2015

houndci-bot Mar 26, 2015

henrikssn commented Mar 26, 2015

henrikssn commented Mar 26, 2015

ghost commented Mar 26, 2015

davidwessman commented Mar 26, 2015

Switch auth system to cancan WIP #69

Switch auth system to cancan WIP #69

Conversation

henrikssn commented Mar 19, 2015

houndci-bot Mar 19, 2015

Choose a reason for hiding this comment

davidwessman commented Mar 19, 2015

henrikssn commented Mar 19, 2015

jforberg commented Mar 19, 2015

davidwessman commented Mar 20, 2015

houndci-bot Mar 21, 2015

Choose a reason for hiding this comment

houndci-bot Mar 21, 2015

Choose a reason for hiding this comment

houndci-bot Mar 26, 2015

Choose a reason for hiding this comment

houndci-bot Mar 26, 2015

Choose a reason for hiding this comment

henrikssn commented Mar 26, 2015

jforberg commented Mar 26, 2015

houndci-bot Mar 26, 2015

Choose a reason for hiding this comment

henrikssn commented Mar 26, 2015

henrikssn commented Mar 26, 2015

ghost commented Mar 26, 2015

davidwessman commented Mar 26, 2015