Controller tests #70
Merged
Controller tests #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| require 'rails_helper' | ||
|
|
||
|
|
||
| def sign_in(user = double('user')) |
There was a problem hiding this comment.
Assignment Branch Condition size for sign_in is too high. [26.02/15]
| RSpec.configure do |config| | ||
| config.include Devise::TestHelpers, :type => :controller |
| @@ -0,0 +1,17 @@ | |||
| #encoding: UTF-8 | |||
|
Will start here as well after CafeModule is live. Good to have some examples to go after as well, nice setup with Devise-helpers + the new factories. |
|
The Rent tests have been changed in #52, does still need some controller-test. |
| @@ -0,0 +1,18 @@ | |||
| #encoding: UTF-8 | |||
Closed
| def candidate_params | ||
| params.require(:candidate).permit(:profile_id,:post_id,:stil_id,:email,:phone,:motivation, :name,:lastname) | ||
| params.require(:candidate).permit(:profile_id, :post_id, :stil_id, :email, :phone, :name, :lastname) |
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Extra empty line detected at block body end.
|
This shit seriously never ends :O |
| val = validate_uniqueness_of(:profile_id). | ||
| scoped_to(:post_id, :election_id). | ||
| with_message('har redan en likadan kandidatur'). | ||
| on(:create) |
There was a problem hiding this comment.
Align the operands of an expression in an assignment spanning multiple lines.
| @@ -50,6 +50,9 @@ | |||
| # https://relishapp.com/rspec/rspec-rails/docs | |||
| config.infer_spec_type_from_file_location! | |||
|
|
|||
|
|
|||
davidwessman
pushed a commit
that referenced
this pull request
Mar 20, 2015
Merging test setup + candidate tests.
|
This PR was deployed to Production. Reference: d86e1fe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds controller tests.
We should start focusing on authentication tests to support #69.
Work in progress. Help is welcome.