-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build binary for node v8 #174
Conversation
Install node-gyp and node-pre-gyp globally and downgrade npm to 4.2.0 to work around bugs in npm@5.
@es128 This should be good to go now. |
I had done something similar in #171, but some of the builds kept failing. Haven't been able to to give this any attention since then. I suppose we should just drop the failing iojs versions at this point. Not worth holding up v8 for them. |
NAN no longer works with them and they have been out of support for a long time now. I don't think we can guarantee things will work with v0.10 and v0.12 either because of nodejs/nan#676.
Ah, so you did. Weird, I never got a notification for #171. I've added a commit that drops io.js from the matrix, with a note in the commit log that v0.10 and v0.12 may be fickle because of nodejs/nan#676. |
Any chance of a release now that this has been merged? 🙏 🙇 |
Yes. Travis is being super slow right now, but I'll |
Something went wrong on the tagged build. Pushed a fixup attempt, waiting for it to get through Travis again. |
Hi @es128 - did you ended up publishing the version? |
Experiment to see if my hunches in #169 (comment) are correct (or at least a step in the right direction.)