Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build binary for node v8 #174

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Build binary for node v8 #174

merged 2 commits into from
Jun 8, 2017

Conversation

bnoordhuis
Copy link
Contributor

Experiment to see if my hunches in #169 (comment) are correct (or at least a step in the right direction.)

Install node-gyp and node-pre-gyp globally and downgrade npm to 4.2.0 to
work around bugs in npm@5.
@bnoordhuis
Copy link
Contributor Author

@es128 This should be good to go now.

@es128
Copy link
Contributor

es128 commented Jun 7, 2017

I had done something similar in #171, but some of the builds kept failing. Haven't been able to to give this any attention since then.

I suppose we should just drop the failing iojs versions at this point. Not worth holding up v8 for them.

NAN no longer works with them and they have been out of support for a
long time now.

I don't think we can guarantee things will work with v0.10 and v0.12
either because of nodejs/nan#676.
@bnoordhuis
Copy link
Contributor Author

Ah, so you did. Weird, I never got a notification for #171.

I've added a commit that drops io.js from the matrix, with a note in the commit log that v0.10 and v0.12 may be fickle because of nodejs/nan#676.

@es128 es128 merged commit 03cb46d into fsevents:master Jun 8, 2017
@es128 es128 mentioned this pull request Jun 8, 2017
@jescalan
Copy link

jescalan commented Jun 8, 2017

Any chance of a release now that this has been merged? 🙏 🙇

@es128
Copy link
Contributor

es128 commented Jun 8, 2017

Yes. Travis is being super slow right now, but I'll npm publish after the builds complete successfully.

@es128
Copy link
Contributor

es128 commented Jun 9, 2017

Something went wrong on the tagged build. Pushed a fixup attempt, waiting for it to get through Travis again.

@kazazor
Copy link

kazazor commented Jun 11, 2017

Hi @es128 - did you ended up publishing the version?

@bnoordhuis bnoordhuis deleted the node8 branch June 12, 2017 09:29
This was referenced Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants