Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to build for node v11 #250

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Update to build for node v11 #250

merged 1 commit into from
Jan 15, 2019

Conversation

pipobscure
Copy link
Contributor

As per #244 (comment)

Why not, releasing NAPI will take until April, until then we'll just get complaints.

Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of it!

@pipobscure pipobscure merged commit 85b3166 into fsevents:v1.x Jan 15, 2019
@pipobscure pipobscure deleted the v1.2.5 branch January 15, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants