Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCS.ProjectCracker on dotnet core - msbuild version #582

Closed
ncave opened this issue Jun 17, 2016 · 4 comments
Closed

FCS.ProjectCracker on dotnet core - msbuild version #582

ncave opened this issue Jun 17, 2016 · 4 comments

Comments

@ncave
Copy link
Contributor

ncave commented Jun 17, 2016

Here is an outstanding issue for the dotnet core implementation of FCS.ProjectCracker:

  1. The FSharp.Compiler.Service.ProjectCracker depends on building the cracked project with MSBuild to get the references from it, but:
  2. The latest MSBuild (installed per this) does not seem to be able to build older .fsproj projects, or at least not out of the box when I tried it.

This will probably improve when the next release of VS 15, please share if there is a MSBuild version that works with older fsharp projects.

In the mean time, some progress can be made by taking in #566 so at least the result after cracking has the project options and files, even if it cannot build properly to get the references (perhaps not everybody needs the references).

It's entirely possible that due to limited information I'm missing the big picture on where msbuild xplat is going, if that's the case please ignore.

@7sharp9
Copy link
Member

7sharp9 commented Jun 17, 2016

Having no msbuild in the equation would be nice. msbuild dependent project are a major pain, it doesn't have to be that way.

@enricosada
Copy link
Contributor

@ncave We need to ask msbuild repo team, i's open now, can you open an issue there about older fsproj?
also /cc @cartermp too because it's interesting for visualfsharp i think, so if we can get some help it's good for everyone.

I'll open one about build and package. We need a package usable by preview1 (or preview2, but is the the same rc2 netcore)
Problem is, it's not a good idea to use dev feed.
Lot of strange stuff there ( rc2 rc3 ), and doing -* for deps may give wrong version or not working with preview1 sdk.
Really it'is a pain to stay bleeding edge in dev feed, let's avoid it if possible, lost too much time. But now there is a working released preview1 so i am happy to use it and avoid pain

@ncave
Copy link
Contributor Author

ncave commented Jun 21, 2016

Here is the link to the issue on the MSBuild repo: #709
Looks like it's not possible at the moment, but perhaps in VS 15.

dsyme added a commit to dsyme/FSharp.Compiler.Service that referenced this issue Jun 29, 2016
Integrate all the latest from visualfsharp\master
@ncave
Copy link
Contributor Author

ncave commented Aug 31, 2017

Closing as no longer seems relevant.

@ncave ncave closed this as completed Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants