Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netcore build step fix #576

Merged
merged 2 commits into from
Jun 14, 2016
Merged

Netcore build step fix #576

merged 2 commits into from
Jun 14, 2016

Conversation

ncave
Copy link
Contributor

@ncave ncave commented Jun 10, 2016

  • Fixed codegen build step regression.
  • Added netcore target as required for the build to pass (appveyor).
  • Allow osx mono:latest (mono:4.4.0) target to fail (travis ci).

@dsyme dsyme merged commit 6d379d2 into fsharp:master Jun 14, 2016
@dsyme
Copy link
Contributor

dsyme commented Jun 14, 2016

OK great!

@ncave ncave deleted the netcore branch June 14, 2016 15:59
@7sharp9
Copy link
Member

7sharp9 commented Jun 17, 2016

@dsyme / @ncave So how can I build FCS on dotnetcore, are there prereqs other than dotnetcore?

@ncave
Copy link
Contributor Author

ncave commented Jun 17, 2016

On Windows, nothing else needed, just run "build DotnetCliBuild" or "build DotnetCliTests".
On osx/linux - netcore versions of FAKE/FsLex/FsYacc still WIP (maybe @enricosada can help) so mono codegen still required, but builds fine after that on dotnetcore. Build binaries are already available in the appveyor build and nuget feed (please ignore v1.0.0 as it is old, there is a more recent -alpha- version).

@enricosada
Copy link
Contributor

@ncave GREAT WORK!

i added a comment #465 (comment) about the dependencies and merge of binaries, but i think is ok.

Fake i dunno atm,
the FsLexYacc need some merge from open source and visualfsharp version, so i cannot do that soon, but are extenal tools, so it's ok to run these with mono i think.

@ncave
Copy link
Contributor Author

ncave commented Jun 17, 2016

@7sharp9 @enricosada I've added some pending issues with the dotnet core version: #581 and #582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants