Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that F# 3.1 additions only use the FileSystem API and not System.IO.* directly #17

Closed
ghost opened this issue Jan 7, 2014 · 0 comments

Comments

@ghost
Copy link

ghost commented Jan 7, 2014

All file system operations in FSharp.Compiler.Service should go through the FileSystem API in the compiler, to allow the file system to be replaced by the host of this component.

This was carefully checked for F# 3.0, but we shold also check this for F# 3.1 code additions.

@ghost ghost closed this as completed Jan 17, 2014
dsyme pushed a commit to dsyme/FSharp.Compiler.Service that referenced this issue Mar 23, 2015
Closes fsharp#17

commit 3d639ab68e247b52bbbbcc83d48b908e7db447af
Author: latkin <latkin@microsoft.com>
Date:   Thu Jan 15 13:43:40 2015 -0800

    Cleaning up tests configs

commit cbf4d768a31e7dc47b2acdabc1064e940eeb09e2
Author: Steffen Forkmann <steffen.forkmann@msu-solutions.de>
Date:   Thu Jan 15 16:38:35 2015 +0100

    Fix calls in #if EXTENSIONTYPING

commit fd548e32c961e45bbee1d2a90188a93c27c36170
Author: Steffen Forkmann <steffen.forkmann@msu-solutions.de>
Date:   Thu Jan 15 16:21:08 2015 +0100

    Reorder build order in proto-Compiler

commit 8968e4f2e5e4c8761975a2b763c439be68ca3321
Author: xepaul <edwardpaul44@gmail.com>
Date:   Tue Nov 18 23:59:43 2014 +0000

    Added Tests

commit 3fd49318354ad64af7a151c173983ce46bd5913a
Author: xepaul <edwardpaul44@gmail.com>
Date:   Thu Nov 13 23:27:27 2014 +0000

    type argument bug fix

commit 848cacfec64df7f8a5c2d86ca46cf65aab1fae76
Author: xepaul <edwardpaul44@gmail.com>
Date:   Sun Sep 7 15:36:49 2014 +0100

    Changes following PR comments :-
    match styling change.
    added open module to remove fully qualified path
    removed unnecessary comment  "//need to hide"  added during prototyping

commit 0b2381f0f398627bff0e5f47c67614d8b2ebaae4
Author: xepaul <edwardpaul44@gmail.com>
Date:   Tue Jul 22 01:38:18 2014 +0100

    Experiment to support assigning values to extension properties at initialization
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants