Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong assembly resolution on Release mode #246

Closed
dungpa opened this issue Oct 27, 2014 · 2 comments
Closed

Wrong assembly resolution on Release mode #246

dungpa opened this issue Oct 27, 2014 · 2 comments
Labels

Comments

@dungpa
Copy link
Contributor

dungpa commented Oct 27, 2014

FCS resolves project references to Debug mode although current project is on Release mode. Here is an excerpt of FSharpProjectOptions:

GetProjectCheckerOptions: ProjectFileName: C:\VFPT\tests\FSharpVSPowerTools.Tests\FSharpVSPowerTools.Tests.fsproj, ProjectFileNames: [|"C:\AppData\Local\Temp.NETFramework,Version=v4.5.AssemblyAttributes.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\ProjectParser.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\ExternalProjectProvider.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\TestHelpers.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\MockDTE.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\Mocks.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\VsTestBase.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\SyntaxConstructClassifierTests.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\ResolveUnopenedNamespaceSmartTaggerTests.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\HighlightUsageTaggerTests.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\FormattingTests.fs";
"C:\VFPT\tests\FSharpVSPowerTools.Tests\DepthTaggerTests.fs"|], FSharpProjectOptions: [|"-o:obj\Release\FSharpVSPowerTools.Tests.dll"; "--debug:pdbonly";
"--noframework"; "--define:TRACE";
"--doc:bin\Release\FSharpVSPowerTools.Tests.XML"; "--optimize+";
"--platform:anycpu";
"-r:C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\IDE\PublicAssemblies\EnvDTE.dll";
"-r:C:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\IDE\PublicAssemblies\EnvDTE80.dll";
"-r:C:\VFPT\packages\Foq\lib\net45\Foq.dll";
"-r:C:\VFPT\packages\FSharp.Compiler.Service\lib\net45\FSharp.Compiler.Service.dll";
"-r:C:\Program Files (x86)\Reference Assemblies\Microsoft\FSharp.NETFramework\v4.0\4.3.0.0\FSharp.Core.dll";
"-r:C:\VFPT\packages\FSharp.ViewModule.Core\lib\net45\FSharp.ViewModule.Core.Wpf.dll";
"-r:C:\VFPT\src\FSharpVSPowerTools.Core\bin\Debug\FSharpVSPowerTools.Core.dll";
"-r:C:\VFPT\bin\FSharpVSPowerTools.dll";
"-r:C:\VFPT\src\FSharpVSPowerTools.Logic\bin\Debug\FSharpVSPowerTools.Logic.dll";

Notice that *.Core.dll and *.Logic.dll refer to their bin\Debug folders.

Downstream bug report fsprojects-archive/zzarchive-VisualFSharpPowerTools#790

@dungpa dungpa added the bug label Oct 27, 2014
@rneatherway
Copy link
Member

Hi Phan, do you pass in the relevant property (i.e. Configuration=Release) when you call for the project options, or is the project file actually changed to default to that configuration?

@dungpa
Copy link
Contributor Author

dungpa commented Oct 28, 2014

Sorry, I was confusing myself. I read arguments from Visual F# Tools, not from project files. It's not a bug from FCS.

The issue is now reported at the right place https://visualfsharp.codeplex.com/workitem/164.

@dungpa dungpa closed this as completed Oct 28, 2014
dsyme pushed a commit to dsyme/FSharp.Compiler.Service that referenced this issue Jul 8, 2015
fixes fsharp#246
closes fsharp#391

commit 2c37b20d129a231a16d2e64cbf2f007aa73e40c4
Author: enricosada <enrico@sada.io>
Date:   Wed Apr 29 18:57:04 2015 +0200

    fix invalid already rendered folder error

    fix invalid already rendered folder error when a project contains
    folders with same name

commit b8d03011db57b3b5df66c31d3a1564352c947cd1
Author: enricosada <enrico@sada.io>
Date:   Wed May 6 23:30:12 2015 +0200

    add regression tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants