-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New home page #317
New home page #317
Conversation
Could you please send a link to the preview? Thanks! Is it this one? http://fsharporg.apphb.com/ |
It is, with the new logo of course. |
@TahaHachana If you grab the latest, full favicon support for all devices/resolutions (and the new logo) are in place. It'd be nice to see these in the design. Below the navigation bar, right now, the font is 28px, with a line height of 40 and 1px letter spacing. Could you try changing to something around 20px font, no line height override, and no extra letter spacing? It looks great in the header, but its a "bit much" through the rest of the page. |
Hi @TahaHachana, I took a look with @mathias-brandewinder. We think it's looking fantastic! We did come to the conclusion that we think the logo and "Install" that's currently on the right should likely be first in the flow, over on the left? When we look on a small sceen (admittedly by reducing the browser size on a desktop) then all we see is text, no logo etc. In contrast, http://fsharp.org shows the logo first We also wonder if replacing the logo might make things feel fairly different since there won't be the big F#, so it would be good to see that in place But it feels like this is getting very close! |
I deployed two new preview versions:
You'll notice that I used the 256X256 logo, the 128X128 looks too small. |
I'd recommend dropping the animation on the logo itself. I don't "love" it As for logo on left or right - I actually like both versions, especially -Reed On Sat, Oct 4, 2014 at 11:39 PM, Taha Hachana notifications@github.com
|
@TahaHachana Would it be possible to make the testimonials and sponsors order and list "randomly" from the total list of both? It'd be nice if they could be randomly selected for including on the main page by default, with each view a different set initially. |
For the sponsors section it's possible to shuffle the logos after the page loads, this functionality is available in the preview: http://fsharporg.apphb.com/. |
FYI, the sponsors section is now blocked by the EasyList list ( |
@cdrnet Changed the class name, it should show up again now. |
@TahaHachana indeed, it does. Thanks! |
Minor nit - change "Corporate Sponsors" to "Corporate Supporters". These companies have indicated support for F# and willingness to use the logo on the front page, but do not "sponsor" it (though they may contribute in other ways). |
@TahaHachana Removing the animation fixed the iOS issues. I'm actually liking the logo on right/top version better, the more I look at it. Re: randomizing the testimonials - having some in place, then swapping out at load might be a good idea. We could pick and choose the ones that provide the best SEO keywords that way, but still prevent certain ones from being seen more than others. Seems like a very nice option for that. |
I implemented testimonials shuffling in the preview based on this selection, the pull request is also up to date. |
Great work. A couple of things:
|
@dsyme I actually like the current menu bar behavior (since it's only on the main page). It keeps the header bar area front-and-center. On mobile, the menu bar is relatively large, so putting it at the top detracts from the logo and text, I think. On other pages, the menu is always anchored at the top (since there is no header area). That being said, I think this is in a great state right now, even if its not "perfect". I'd like to propose we merge this, and then try to do clean ups and changes over time for any other issues that crop up. We'll get a lot more visibility and traction if there are problems once it's live, and I feel that, in its current state, it's already significantly better than the current main page. |
I like the new design, but I miss is the links on the left. They currently are a duplication of the menus, but I think they are more usable and discoverable. |
@dsyme For the testimonials, should each snippet point to the full testimonial (using the permalinks) or just to /testimonials? |
@TahaHachana To the permalink. @ReedCopsey When I look at http://fsharporg.apphb.com on my mobile, the menu choice box (horizontal bar box) doesn't display at all until I scroll down at least 1.5 full pages. (This happens on a reduced-size desktop window also). It feels like the menu is a bit detached - . The menu should be visible on the first screen for all display sizes, shouldn't it? But I agree it should be pretty easy to fix. It does feel like we could go ahead and merge soon - @TahaHachana can you give as an all-clear when you're done with updates for the testimonials? BTW how does this affect the design and layout of secondary pages? (guides, install etc.) |
The testimonials section uses the permalinks now. For inner pages, this is for example how the first videos page is going to look like. Regarding the navbar, if it's too much below the fold when viewed on mobile we can display it at the top of the page on small and medium devices and under the header on large ones. |
Is there a problem with how inner pages would look like or something? |
The inner page looks good. I think this is almost ready to merge. One request - can we keep it simple and make sure the navbar (or reduced bar-box) is always showing, preferably at the top? At the moment on my laptop (IE 11, 1366x768) the navbar is at the bottom, and when you click the actual menus they are displayed off the bottom of the screen where you can't see them. |
The navbar is now always at the top of the page, I think this is better for both new and regular visitors. |
We will proceed with a trial merge of this! |
Issues I've seen so far:
Otherwise everything is looking good! |
Oh, when you press "Install" on the front page the dropdown shows below, partly off-screen. |
On smaller screen sizes, when using the minimized toolbar with the three stripes, the second-level of toolbar choices shows in grey font |
Preview: http://fsharporg.apphb.com/