Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

037 deprecations #38

Merged
merged 7 commits into from
Aug 21, 2020
Merged

037 deprecations #38

merged 7 commits into from
Aug 21, 2020

Conversation

pheerai
Copy link
Member

@pheerai pheerai commented Feb 2, 2020

As mentioned in #37 , this reduces deprecations on our side.

This includes the following changes:

  • Update dependencies
  • Replace usages of JSON_TYPE with JSONType

@pheerai pheerai requested a review from chizeta0 February 2, 2020 17:51
@codecov
Copy link

codecov bot commented Feb 2, 2020

Codecov Report

Merging #38 into develop will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #38      +/-   ##
===========================================
- Coverage    99.60%   99.59%   -0.00%     
===========================================
  Files            5        5              
  Lines          246      242       -4     
===========================================
- Hits           245      241       -4     
  Misses           1        1              
Impacted Files Coverage Δ
.../bayernfahrplan/fahrplanparser/data/substitution.d 100.00% <ø> (ø)
...ce/bayernfahrplan/fahrplanparser/data/exceptions.d 100.00% <100.00%> (ø)
...rce/bayernfahrplan/fahrplanparser/json/jsonUtils.d 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af4442b...1daf46c. Read the comment docs.

@pheerai
Copy link
Member Author

pheerai commented Mar 25, 2020

Ping, @chizeta0 ?

ghost91-
ghost91- previously approved these changes Aug 21, 2020
Copy link
Contributor

@ghost91- ghost91- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, but there seems to be an issue with CI. dub build ... in line 6 in travis.sh seems to segfault.

@pheerai
Copy link
Member Author

pheerai commented Aug 21, 2020

There seems to ba some issue with Travis CI as a whole, e.g. it didn't detect any F3L-Repos for me and more than 50% of the machines for my personal repos failed before even starting the tests.
With all the problems TCI is having I'm voting for removing it all together, it's not helpfull in its current state.

@ghost91-
Copy link
Contributor

We could try switching to GitHub actions. As of today, D is supported by default (https://forum.dlang.org/thread/zolkicvjrfkeoldkwvip@forum.dlang.org). Alternatively, I have had good experiences with Circle CI.

@pheerai
Copy link
Member Author

pheerai commented Aug 21, 2020

In that vote for using GitHub actions, they seem to work pretty good and are integrated properly.

@ghost91-
Copy link
Contributor

I'll try setting it up

Copy link
Contributor

@ghost91- ghost91- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, before merging this to develop, we should adjust the badge in the README to not use travis anymore. I'll edit it.

@pheerai pheerai merged commit d3a2212 into develop Aug 21, 2020
@pheerai pheerai deleted the 037_deprecations branch August 21, 2020 11:38
@pheerai pheerai mentioned this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants