-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
037 deprecations #38
037 deprecations #38
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #38 +/- ##
===========================================
- Coverage 99.60% 99.59% -0.00%
===========================================
Files 5 5
Lines 246 242 -4
===========================================
- Hits 245 241 -4
Misses 1 1
Continue to review full report at Codecov.
|
Ping, @chizeta0 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, but there seems to be an issue with CI. dub build ...
in line 6
in travis.sh
seems to segfault.
There seems to ba some issue with Travis CI as a whole, e.g. it didn't detect any F3L-Repos for me and more than 50% of the machines for my personal repos failed before even starting the tests. |
We could try switching to GitHub actions. As of today, D is supported by default (https://forum.dlang.org/thread/zolkicvjrfkeoldkwvip@forum.dlang.org). Alternatively, I have had good experiences with Circle CI. |
In that vote for using GitHub actions, they seem to work pretty good and are integrated properly. |
I'll try setting it up |
chore: Create bayernfahrplan-workflow.yml and remove travis related files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, before merging this to develop, we should adjust the badge in the README to not use travis anymore. I'll edit it.
As mentioned in #37 , this reduces deprecations on our side.
This includes the following changes:
JSON_TYPE
withJSONType