Fix bug in LinearExpression.Evaluate #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewcrews
reviewed
Jan 3, 2021
| @@ -216,7 +216,7 @@ and | |||
| | AddLinearExpression (lExpr, rExpr) -> getRec (fun l -> getRec cont l rExpr) decisions lExpr | |||
| getRec id Set.empty expr | |||
|
|
|||
| static member internal Evaluate (decisionMap:Map<Decision, float>) (expr:LinearExpression) : float = | |||
| static member internal Evaluate (getDecisionCoef: Decision -> float) (expr:LinearExpression) : float = | |||
There was a problem hiding this comment.
I'm curious why you went with this type versus the original Map?
There was a problem hiding this comment.
Map<'a, 'b> is more restrictive than 'a -> 'b. The tests doesn't care what Decisions are in the LinearExpressions. From the perspective of the tests, it suffices for the coefficient corresponding to each Decision to be 1.0.
matthewcrews
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153
I made two changes in order to keep the tests simple. First, I mades things in the
Flipsproject withinternalscope visible to theFlips.Testsproject. Second, I weakened an argument type of the internal methodLinearExpression.Evaluate.It is unfortunate that these two new tests are essentially the same as the two tests above them. This is caused by the equivalently duplicate code between
LinearExpression.ReduceandLinearExpression.Evaluate. I expect to remove that duplication one day, but not soon.