-
-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] close handle when remWatch open in getIno #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Would this be an excuse for a windows_test.go
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I'm not sure if we can add a test case around this issue. What do you think?
@brokenjacky Would you update this? |
f8445c9
to
9936dc0
Compare
I rebased this on the latest main and I added the test case you wrote @mattn; is that test case finished or were you still working on it? |
9936dc0
to
e929749
Compare
Note: the tests pass even without the syscall.CloseHandle()
e929749
to
c3153fe
Compare
Add test for remWatch, which #288 fixed. Co-authored-by: jie <jie@tt.com> Co-authored-by: Nahum Shalman <nahamu@gmail.com> Co-authored-by: Martin Tournoij <martin@arp242.net>
What does this pull request do?
when i remWatch a directory using remWatch, and then delete the directory ,and i find the directory is still in there but i can't access because a handle is still open
Where should the reviewer start?
How should this be manually tested?
see #42 ,the gist by timshannon (https://gist.github.com/timshannon/603f92824c5294269797)