enable updating of publicHost through server config

fsouza · Mar 10, 2022 · fba1be0 · fba1be0
1 parent 71fdd6b
commit fba1be0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/fakestorage/config.go b/fakestorage/config.go
@@ -9,6 +9,7 @@ func (s *Server) updateServerConfig(r *http.Request) jsonResponse {
 
 	var configOptions struct {
 		ExternalUrl string `json:"externalUrl,omitempty"`
+		PublicHost  string `json:"publicHost,omitempty"`
 	}
 	err := json.NewDecoder(r.Body).Decode(&configOptions)
 	if err != nil {
@@ -22,5 +23,9 @@ func (s *Server) updateServerConfig(r *http.Request) jsonResponse {
 		s.externalURL = configOptions.ExternalUrl
 	}
 
+	if configOptions.PublicHost != "" {
+		s.publicHost = configOptions.PublicHost
+	}
+
 	return jsonResponse{status: http.StatusOK}
 }
diff --git a/fakestorage/server_test.go b/fakestorage/server_test.go
@@ -276,16 +276,25 @@ func TestUpdateServerConfig(t *testing.T) {
 		name                string
 		requestBody         string
 		expectedExternalUrl string
+		expectedPublicHost  string
 	}{
 		{
 			"PUT: empty json",
 			"{}",
 			"https://0.0.0.0:4443",
+			"0.0.0.0:4443",
 		},
 		{
 			"PUT: externalUrl provided",
 			"{\"externalUrl\": \"https://1.2.3.4:4321\"}",
 			"https://1.2.3.4:4321",
+			"0.0.0.0:4443",
+		},
+		{
+			"PUT: publicHost provided",
+			"{\"publicHost\": \"1.2.3.4:4321\"}",
+			"https://1.2.3.4:4321",
+			"1.2.3.4:4321",
 		},
 	}
 
@@ -317,6 +326,7 @@ func TestUpdateServerConfig(t *testing.T) {
 			}
 
 			assert.Equal(t, test.expectedExternalUrl, server.externalURL)
+			assert.Equal(t, test.expectedPublicHost, server.publicHost)
 		})
 	}
 }