Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createWriteStream() with resumable true results in absolute URLs error on 1.45.1 #1170

Closed
byumark opened this issue May 17, 2023 · 1 comment · Fixed by #1184
Closed

createWriteStream() with resumable true results in absolute URLs error on 1.45.1 #1170

byumark opened this issue May 17, 2023 · 1 comment · Fixed by #1184
Labels

Comments

@byumark
Copy link

byumark commented May 17, 2023

We recently upgraded to fake-gcs-server 1.45.1 and started getting the following error from google-cloud/storage when streaming to the fake gcs server using createWriteStream():

TypeError: Only absolute URLs are supported

When we move back to 1.45.0, then we no longer have the issue. Also, if we set resumable to false then 1.45.1 does not cause an error. For example:

createWriteStream({ resumable: false })

@fsouza fsouza added the bug label May 17, 2023
fsouza added a commit that referenced this issue May 27, 2023
This is a regression introduced in #1159: when default parameters are
used, the external URL would be empty, breaking resumable uploads.

Fixes #1166.
Fixes #1170.
@fsouza
Copy link
Owner

fsouza commented May 27, 2023

Thanks for reporting and apologies for the breakage. This is the same issue as #1166 (different SDKs have different error messages).

I broke it in #1159. #1184 fixes it.

@fsouza fsouza closed this as completed in d2c9a5d May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants