Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XML Multipart uploads? #852

Open
wjones127 opened this issue Jul 9, 2022 · 5 comments
Open

Support XML Multipart uploads? #852

wjones127 opened this issue Jul 9, 2022 · 5 comments

Comments

@wjones127
Copy link

We are looking at integration testing with this server for object_store_rs and are implementing bindings for the XML Multipart upload. It would be nice to be able to test those methods with this server.

Is this repo open to contributions? If so I'd be willing to attempt a PR.

@fsouza
Copy link
Owner

fsouza commented Jul 15, 2022

We are looking at integration testing with this server for object_store_rs and are implementing bindings for the XML Multipart upload. It would be nice to be able to test those methods with this server.

Hey, yeah, feel free to send a PR. I'm not that familiar with the XML APIs, but we can work on it together.

@zacker150
Copy link

Is this still on the roadmap?

@wjones127
Copy link
Author

Apologies, I don't think I'll be getting to this anytime soon.

@fsouza
Copy link
Owner

fsouza commented Jan 11, 2023

@zacker150 I don't have many free cycles right now, but I'll leave this issue open in case other folks want to work on this. Thank you very much for checking in!

@goober
Copy link
Contributor

goober commented Apr 2, 2023

I have an implementation almost ready for review. Just want to make sure that my first PR for listing objects using the XML api get merged before.

onpaws added a commit to splitgraph/seafowl that referenced this issue May 9, 2023
- Temporarily disable fake-gcs-server test integration until
  github.com/fsouza/fake-gcs-server/issues/852 gets
  resolved. Underscore seems a more idiomatic way to handle
onpaws added a commit to splitgraph/seafowl that referenced this issue May 10, 2023
- fsouza/fake-gcs-server#852 (comment)
  is anticipated to deliver the XML multpart upload API that this test
  depends on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants