Fix hijack dial

[benmccann]

No description provided.

[hmarr]

The type assertion on line 218 still seems to cause issues when a unix socket is used.

Perhaps replace

if err := rwc.(*net.TCPConn).CloseWrite(); err != nil {
    fmt.Fprintf(errStream, "Couldn't send EOF: %s\n", err)
}

with

if err := rwc.(interface{ CloseWrite() error }).CloseWrite(); err != nil {
    fmt.Fprintf(errStream, "Couldn't send EOF: %s\n", err)
}

[benmccann]

@hmarr i've done exactly that in another pull request already #52

[hmarr]

Ah, gotcha.

[andrewsmedina]

@benmccann thank you! Can you write a code to test it? If you need help let me know.

[benmccann]

@andrewsmedina thanks for the help merging these commits! would love to get this last one in. any ideas on how to proceed? i don't really know how to write a test for this one

[benmccann]

maybe this one you could merge and write a test for? the issue is that hijack does not have an existing test so i would have to write one from scratch and don't know enough go to know how to do that

[andrewsmedina]

@benmccann I will do it :)

[benmccann]

awesome. thanks you Andrews! i will look at how you did it, so hopefully i can next time

[benmccann]

btw, think we could merge this change now and then do the test in another commit?

[benmccann]

awesome! thank you so much!