Support IdentityToken in AuthConfiguration #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for the sending and parsing of an IdentityToken. IdentityToken's are retrieved via the /auth call (see AuthCheck) and can then be used in place of the password. After a successful `docker login` a users `.dockercfg` can contain an identity token in place of the original username and password in the auth field.
Having this present appears to break the authentication. So I have dropped it from being populated.
This reverts commit ae31b47.
fsouza
requested changes
Aug 11, 2018
There was a problem hiding this comment.
Hi @GeorgeMac, thank you very much for contributing!
Can you take a look at the build failure?
auth_test.go
Outdated
| read := strings.NewReader(fmt.Sprintf(`{"auths":{"docker.io":{"auth":"%s","identitytoken":"sometoken"}}}`, auth)) | ||
| ac, err := NewAuthConfigurations(read) | ||
| if err != nil { | ||
| t.Error(err) |
There was a problem hiding this comment.
Can you replace this with t.Fatal(err) so the test execution aborts after failing?
|
🙇 my pleasure. I will jump on that now. |
The docker config auths field is still expected to contain a base64 encoded string which is a colon ':' delimited username and password. Even if the password is blank. This updates the test to include a trailing colon in the auths payload. The password is empty as an identitytoken should be provided.
|
🎉 amazing, thank you for the speedy response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the sending and parsing of an
IdentityToken in an AuthConfiguration. IdentityToken's are retrieved via the /auth call (see
AuthCheck) and can then be used in place of the password. After a
successful
docker logina users.dockercfgcan contain an identitytoken in place of the original username and password in the auth field.
See: https://docs.docker.com/engine/api/v1.25/#section/Authentication
Also see official docker types https://godoc.org/github.com/docker/docker/api/types#AuthConfig