Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container operations divided separate files #832

Merged
merged 5 commits into from
Jun 2, 2020
Merged

Container operations divided separate files #832

merged 5 commits into from
Jun 2, 2020

Conversation

UmutComlekci
Copy link
Contributor

For better reading and development, container.go file divided separate files

@fsouza
Copy link
Owner

fsouza commented May 18, 2020

Nice thanks for taking care of this, I'll have a look later in the week, but in the meantime can you split container_test.go too?

@fsouza
Copy link
Owner

fsouza commented May 22, 2020

Thank you very much! I'll look into this over the weekend.

fsouza
fsouza approved these changes Jun 2, 2020
View reviewed changes
Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much and sorry for the delayed feedback. I'll move the errors to a dedicated file after merging.

@fsouza fsouza merged commit 23318e6 into fsouza:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UmutComlekci @fsouza