Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify SGFFileFilter #25

Closed
barrybecker4 opened this issue Jan 22, 2018 · 2 comments
Closed

simplify SGFFileFilter #25

barrybecker4 opened this issue Jan 22, 2018 · 2 comments

Comments

@barrybecker4
Copy link
Contributor

9 lines can be replaced with 1 using toUppercase instead of all the permutations. I'll make a PR.
barrybecker4 added a commit to barrybecker4/LeelaWatcher that referenced this issue Jan 22, 2018
@barrybecker4
fsparv#25 Simplify SGFFileFilter. Add tests for it.
1fd95d2
@fsparv
Copy link
Owner

fsparv commented Jan 22, 2018

lol, now you've gone and found some of my 2001 code :)... I'm sure there's lots of silliness like that to be cleaned up. I had just learned java when I wrote most of this code. That's simple enough I can merge it at a glance...

fsparv added a commit that referenced this issue Jan 22, 2018
@fsparv
Merge pull request #26 from barrybecker4/25-simplify-SgfFileFilter
2349bce 
#25 Simplify SGFFileFilter. Add tests for it.
@barrybecker4
Copy link
Contributor Author

Closing this since my PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fsparv @barrybecker4