Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update F# compiler on the Travis CI #459

Closed
bentayloruk opened this issue Jun 4, 2014 · 12 comments
Closed

Update F# compiler on the Travis CI #459

bentayloruk opened this issue Jun 4, 2014 · 12 comments

Comments

@bentayloruk
Copy link
Contributor

This PR uses named values on a discriminated union. This is an F# 3.1 language feature and the Travis CI server is compiling with F# 3.0, so the PR breaks the build. Is it possible to update the CI to use 3.1?

@forki
Copy link
Member

forki commented Jun 10, 2014

Actually I don't know. We need someone with mono knowledge. Maybe @7sharp9 can help!?

@7sharp9
Copy link
Member

7sharp9 commented Jun 10, 2014

As far as I know @ovatsus uses 3.1. See: https://github.com/7sharp9/FSharp.Data/blob/master/.travis.yml

@forki
Copy link
Member

forki commented Jun 10, 2014

cool. thanks

@ovatsus
Copy link

ovatsus commented Jun 10, 2014

That that is building from source, which is unfortunate as builds take too long. Maybe the latest binary now would now work?

forki added a commit that referenced this issue Jun 10, 2014
@bentayloruk
Copy link
Contributor Author

Another reason to support it when we can, is that I added DU case value name support to UnionArgParser so we can get an even better FAKE CLI experience fsprojects/Argu#11 (comment)

@forki
Copy link
Member

forki commented Jun 17, 2014

I'd love to use a newer version, but don't know how.

@rneatherway
Copy link
Contributor

The Travis build seems to be working now, so is this still needed? In any case, updating the mono version from 3.4.0 to 3.8.0 in .travis.yml should get you F# 3.1

@forki
Copy link
Member

forki commented Oct 16, 2014

wow F# 3.1 - that sounds cool.

@bentayloruk
Copy link
Contributor Author

I removed my 3.1 feature usage, so I don't need it in the context of this issue. I'll leave it up to @forki if he wants to close this or leave it open until the .travis.yml gets updated.

@forki
Copy link
Member

forki commented Oct 16, 2014

I'd love to see a PR for this.

@rneatherway
Copy link
Contributor

Submitted, we can wait to see if the build goes through cleanly.

On Thu, Oct 16, 2014 at 11:12 AM, Steffen Forkmann <notifications@github.com

wrote:

I'd love to see a PR for this.


Reply to this email directly or view it on GitHub
#459 (comment).

@rneatherway
Copy link
Contributor

This is fixed, issue should be closed.

@forki forki closed this as completed May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants