Linux build failure due to case sensitivity & nunit-console wrong param value spelling #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
regarding issue 1:
|
|
Hm, the Nuget.Core package indeed changed the casing of its ID some time ago: http://www.nuget.org/packages/Nuget.Core/ (sic!) |
|
In my case the spelling of the package folder is different (running ubuntu 14.04 with mono 3.4.0). The package dirs are as created by the first build.sh |
|
ok let's try to update to 2.8.2 |
forki
added a commit
that referenced
this pull request
Jun 17, 2014
Linux build failure due to case sensitivity & nunit-console wrong param value spelling
|
but it's still NuGet.Core.dll .
|
forki
added a commit
that referenced
this pull request
Jun 17, 2014
|
does it work for you? |
|
Just did a fresh clone, sh build.sh and can verify it works. Thnx :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following 2 issues:
1). Build fails in linux + mono (or other systems that are case sensitive) due to wrong case for NuGet.Core.dll dependency in FakeLib
Specifically: in src/app/FakeLib/FakeLib.fsproj, NuGet.Core is referenced by path: ......\packages\NuGet.Core.2.8.1\lib\net40-Client\NuGet.Core.dll which is unresolvable in case sensitive system since the proper path on the file system is: "......\packages\Nuget.Core.2.8.1\lib\net40-Client\NuGet.Core.dll"
This causes the dependency to become unresolved and the xbuild fails
2). Wrong value for /process argument is passed to nunit-console due to spelling error
Specifically: in src/app/FakeLib/UnitTests/NUnit/Common.fs, NUnitProcessModel.SeperateProcessModel, proper spelling is Separate, and in NUnitProcessModel.ParamString "Seperate" is give as the parameter value whereas the /process parameter accepts "Separate" (see: http://www.nunit.org/index.php?p=consoleCommandLine&r=2.6.3)