Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin FSharp.Core dependency #75

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bartelink
Copy link
Member

@bartelink bartelink commented Apr 9, 2024

Triggered by SwensenSoftware/unquote#169

  • Add an explicit FSharp.Core dependency
  • Adjust inadvertent leak of Dotnet.ReproducibleBuilds into the package deps
  • Remove misleading inert superseded settings

@bartelink bartelink marked this pull request as ready for review April 9, 2024 08:59
@bartelink bartelink changed the title Pin deps Pin FSharp.Core dependency Apr 9, 2024
@samritchie
Copy link
Collaborator

Build failure looks like it’s related to the StructuredLogger version in build.fsx, I’ll see if I can work out what it should be

@samritchie
Copy link
Collaborator

Looks like bumping it to 2.2.206 should work - @bartelink is it easier for you to update your branch?

@samritchie
Copy link
Collaborator

Also note I’ve considered bumping FSharp.Core to 6.0.7 as it looks like it will make life easier with tasks - I’ve been working on streams support using a Task based API. Not sure of the tradeoffs here though - open to suggestions.

@bartelink
Copy link
Member Author

I think 6.0.7 is a good call - there's probably the odd gap closed in Arrray, Seq and stuff too
You should be able to push to my branch if you gh pr to retrieve it (and 101 other ways) - in general feel free to do that, but I'll try now
Yes it dos stand to reason the template is gone
my main thing in all of this is for the package not to get a random dependency update due to unqote some day

@bartelink
Copy link
Member Author

(Giving up for now; have time-sensitive stuff this side...)

@samritchie
Copy link
Collaborator

samritchie commented Apr 10, 2024 via email

@bartelink
Copy link
Member Author

Thanks; it's not time sensitive from my perspective.
If unquote reduces dependency to 6.0.0, probably updating unquote can be done as a follow-up to include in the next release
... or not yet, depending on when you want to do task stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants