Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs and update to FAKE 5 #110

Closed
wants to merge 1 commit into from

Conversation

kblohm
Copy link
Contributor

@kblohm kblohm commented Jun 4, 2018

Hi,
in #107 you told me that the docs were broken for some time now, so i thought i might fix that.
At least for me (on windows) they build just fine now.
While i was at it i also updated the build to use FAKE 5.
Some stuff that might still need some work:

  • I did not test the release targets as they require git permissions.
  • build.sh might need some more work, i am not very firm in bash-scripts :/.
  • .travis.yml and appveyor.yml might not be quite right

@kblohm kblohm force-pushed the updateFakeAndDocs branch 3 times, most recently from 695576b to 7521b51 Compare June 4, 2018 21:15
@kblohm
Copy link
Contributor Author

kblohm commented Jun 6, 2018

Any ideas why travis is not working?
I am probably doing something wrong in build.sh. But i have no way to test this locally except for git-bash and that is working fine :/. Some help would be appreciated :)

@kblohm kblohm force-pushed the updateFakeAndDocs branch 3 times, most recently from d314d27 to ceafde9 Compare June 6, 2018 17:56
@panesofglass
Copy link
Collaborator

I'll try on my Ubuntu subsystem later today. Thanks for doing this!

@kblohm
Copy link
Contributor Author

kblohm commented Jun 10, 2018

Soo.. that travis problem was apparently a bug in the dotnet tooling and how they try to resolve dotnet sdk tools that are installed to a none default folder. So i changed the way to bootstrap FAKE from the global tool to a build.proj file.
I also added a HostDocs target to host the docs with AspNetCore, so we dont need to generate the docs with a different root just for testing.

@kblohm
Copy link
Contributor Author

kblohm commented Jun 10, 2018

Ok, its finally working :)

@kblohm kblohm force-pushed the updateFakeAndDocs branch 2 times, most recently from ebeb01d to ad19c3b Compare June 10, 2018 20:37
@panesofglass
Copy link
Collaborator

I merged and added a few clean up commits. I think I broke the HostDocs, but it fixes the paths for the published docs. I am not sure the best way to resolve using local or fixed paths.

@kblohm
Copy link
Contributor Author

kblohm commented Jun 11, 2018

Mh, i was pretty sure gh-pages are fine with relative paths :/.

@kblohm kblohm deleted the updateFakeAndDocs branch June 11, 2018 20:23
@panesofglass
Copy link
Collaborator

panesofglass commented Jun 12, 2018

@kblohm it works okay with relative paths, but the paths in the template were relative to the root, and the root was not set to /FSharp.Control.Reactive, as it needs to be for github pages, i.e. https://fsprojects.github.io/FSharp.Control.Reactive/index.html. The old generate.fsx used an #if RELEASE for using the root, but I'm uncertain how it used that correctly.

@panesofglass
Copy link
Collaborator

In any case, you fixed the documentation generation, and it's now updated! Thanks!

@panesofglass
Copy link
Collaborator

Also, @kblohm, apologies for not cleanly merging, leading this to appear unmerged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants