fix using FSharpLint.Core targeting net
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Error Message: System.TypeInitializationException : The type initializer for 'FSharpLint.Framework.Configuration' threw an exception. ----> System.TypeInitializationException : The type initializer for '<StartupCode$FSharpLint-Core>.$Configuration' threw an exception. ----> System.IO.FileLoadException : Could not load file or assembly 'FParsecCS, Version=1.0.3.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040) ``` That's caused by bad packaging of FParsec ref stephan-tolksdorf/fparsec#34
the v0.31 use the same api (`Result`) for both .NET and .NET Standard target framework.
|
@duckmatt @jgardella ready to review. if it's possibile to have a new version published, will help fix lint in FSAC .NET (ref ionide/FsAutoComplete#336) |
|
Thanks for the PR @enricosada. Looks fine to me, but I will wait for @duckmatt to review since he did the conversion to .NET core. |
|
Looks good, thank you! @enricosada @jgardella I've updated the release notes to update to version 0.10.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
FSharpLint.CoretargetingnetfailsThat's caused by bad packaging of FParsec.
As workaround (and as best practice), multitarget
FSharpLint.Corefor bothnetandnetstandard.Bump version of
Dotnet.ProjInfobecause v0.31 use the same api for .NET and .NET Standard, to minimize changesref stephan-tolksdorf/fparsec#34
ref ionide/FsAutoComplete#336