build.fsx,RELEASE.md: don't push prereleases for relNotes commits #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
force-pushed
the
avoidPreReleaseForReleaseNotesCommit
branch
7 times, most recently
from
f2e2bf0
to
4999ffb
Compare
This might be seen as illogical, because it is visibly much more code than before; however it has some added benefits: * It has a log that explains when a nuget push doesn't happen. * It avoids using GitHubActions specific syntax, which sometimes is tricky to get right (and so, less maintainable). * It improves a helper func to check for whitespace too.
The way we had setup the prerelease push was making unnecessary prerelease packages for the same commit that ends up being mapped to a release. But if we push the tag and the branch at the same time, and check the commit with 'git describe' then we can detect the situation and avert it.
knocte
force-pushed
the
avoidPreReleaseForReleaseNotesCommit
branch
3 times, most recently
from
d50a242
to
fa788db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we had setup the prerelease push was making unnecessary prerelease packages for the same commit that ends up being mapped to a release. But if we push the tag and the branch at the same time, and check the commit with 'git describe' then we can detect the situation and avert it.