New rule UnneededRecKeyword #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mersho
changed the title
Mersho
force-pushed
the
fix-650
branch
2 times, most recently
from
4759778
to
2f2c570
Compare
knocte
changed the title
knocte
reviewed
Dec 28, 2023
|
@Mersho please rebase this, and after that add a commit that renames the rule to UnneededRecKeyword |
Mersho
force-pushed
the
fix-650
branch
2 times, most recently
from
2ab0adb
to
46db572
Compare
|
@webwarrior-ws please review |
knocte
changed the title
This commit resolves red CI on the "Run FSharpLint on itself" step by removing the "rec" keyword from "isNested" function.
Mersho
force-pushed
the
fix-650
branch
5 times, most recently
from
f7df3b8
to
999d8b9
Compare
Additionally, the "symbol" argument does not need parentheses and the name was confusing, so I renamed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #650