Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for .NET Portable Subset #180

Closed
ctaggart opened this issue Sep 29, 2014 · 5 comments
Closed

add support for .NET Portable Subset #180

ctaggart opened this issue Sep 29, 2014 · 5 comments

Comments

@ctaggart
Copy link
Contributor

I have a project that uses the .Net Portable Subset of .NET 4.5:
image

Newtonsoft.Json ships with it as portable-net45+wp80+win8+wpa81:
image

To resolve locally, I added this additional condition to the .fsproj with .NETPortable and the directory path being the differences:

    <When Condition="$(TargetFrameworkIdentifier) == '.NETPortable' And $(TargetFrameworkVersion) == 'v4.5'">
      <ItemGroup>
        <Reference Include="Newtonsoft.Json">
          <HintPath>..\..\packages\Newtonsoft.Json\lib\portable-net45+wp80+win8+wpa81\Newtonsoft.Json.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
@forki
Copy link
Member

forki commented Sep 29, 2014

Thanks will add
On Sep 29, 2014 7:36 AM, "Cameron Taggart" notifications@github.com wrote:

I have a project that uses the .Net Portable Subset of .NET 4.5:
[image: image]
https://cloud.githubusercontent.com/assets/80104/4437509/b66d8d64-4799-11e4-8381-7af4495bf3c2.png

Newtonsoft.Json ships with it as portable-net45+wp80+win8+wpa81:
[image: image]
https://cloud.githubusercontent.com/assets/80104/4437526/37278b26-479a-11e4-9973-f8f2a3d1196d.png

To resolve locally, I added this additional condition to the .fsproj with
.NETPortable and the directory path being the differences:

<When Condition="$(TargetFrameworkIdentifier) == '.NETPortable' And $(TargetFrameworkVersion) == 'v4.5'">
  <ItemGroup>
    <Reference Include="Newtonsoft.Json">
      <HintPath>..\..\packages\Newtonsoft.Json\lib\portable-net45+wp80+win8+wpa81\Newtonsoft.Json.dll</HintPath>
      <Private>True</Private>
      <Paket>True</Paket>
    </Reference>
  </ItemGroup>
</When>


Reply to this email directly or view it on GitHub
#180.

@forki
Copy link
Member

forki commented Sep 29, 2014

can you send me a the proj file for the system-tests

@ctaggart
Copy link
Contributor Author

@forki
Copy link
Member

forki commented Sep 29, 2014

seems to work now.

@ctaggart
Copy link
Contributor Author

This was working when I tested with 0.4.0.9 yesterday.

forki pushed a commit that referenced this issue Jun 3, 2015
Ensure that SSL certificates up to date on Mono
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants