Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/excludedgroups #1696

Merged
merged 5 commits into from
May 23, 2016
Merged

Feature/excludedgroups #1696

merged 5 commits into from
May 23, 2016

Conversation

shortsn
Copy link
Contributor

@shortsn shortsn commented May 20, 2016 •
edited
Loading

Hey paket-team,

i really like paket and want to give something back. I tried to implement the feature requested in #1630 because i think it will be a useful extension.

forki
forki reviewed May 21, 2016
View reviewed changes
src/Paket.Core/PackageMetaData.fs
{ FileName = templateFile.FileName
Contents = CompleteInfo(core, { opt with ExcludedDependencies = newExcludes }) }
| IncompleteTemplate ->
failwith "You should only try to exclude dependencies to template files with complete metadata."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please extend this message to include the filename?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@forki
Copy link
Member

forki commented May 21, 2016

wow cool stuff!

@shortsn
Copy link
Contributor Author

shortsn commented May 22, 2016 •
edited
Loading

Is there anything i can do to fix the build? I dont think that my changes broke it and the failed test "Paket.IntegrationTests.InstallSpecs.#1592" seems to be a problem in other active pull requests too.

When i run the build on locally everything works fine.

@forki
Copy link
Member

forki commented May 22, 2016

I think it's unrelated.
On May 22, 2016 6:46 PM, "shortsn" notifications@github.com wrote:

Is there anything i can do to fix the build? I dont think that my changes
broke it and the failed test "Paket.IntegrationTests.InstallSpecs.#1592
#1592" seems to be a problem
in other active pull requests too.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1696 (comment)

@forki forki merged commit 36edd22 into fsprojects:master May 23, 2016
@forki
Copy link
Member

forki commented May 23, 2016

thanks for this great addition

@shortsn shortsn deleted the feature/excludedgroups branch May 23, 2016 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shortsn @forki