New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/excludedgroups #1696

Merged
merged 5 commits into from May 23, 2016

Conversation

Projects
None yet
2 participants
@shortsn
Contributor

shortsn commented May 20, 2016

Hey paket-team,

i really like paket and want to give something back. I tried to implement the feature requested in #1630 because i think it will be a useful extension.

Show outdated Hide outdated src/Paket.Core/PackageMetaData.fs
{ FileName = templateFile.FileName
Contents = CompleteInfo(core, { opt with ExcludedDependencies = newExcludes }) }
| IncompleteTemplate ->
failwith "You should only try to exclude dependencies to template files with complete metadata."

This comment has been minimized.

@forki

forki May 21, 2016

Member

can you please extend this message to include the filename?

@forki

forki May 21, 2016

Member

can you please extend this message to include the filename?

This comment has been minimized.

@shortsn

shortsn May 21, 2016

Contributor

done

@shortsn

shortsn May 21, 2016

Contributor

done

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 21, 2016

Member

wow cool stuff!

Member

forki commented May 21, 2016

wow cool stuff!

@shortsn

This comment has been minimized.

Show comment
Hide comment
@shortsn

shortsn May 22, 2016

Contributor

Is there anything i can do to fix the build? I dont think that my changes broke it and the failed test "Paket.IntegrationTests.InstallSpecs.#1592" seems to be a problem in other active pull requests too.

When i run the build on locally everything works fine.

Contributor

shortsn commented May 22, 2016

Is there anything i can do to fix the build? I dont think that my changes broke it and the failed test "Paket.IntegrationTests.InstallSpecs.#1592" seems to be a problem in other active pull requests too.

When i run the build on locally everything works fine.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 22, 2016

Member

I think it's unrelated.
On May 22, 2016 6:46 PM, "shortsn" notifications@github.com wrote:

Is there anything i can do to fix the build? I dont think that my changes
broke it and the failed test "Paket.IntegrationTests.InstallSpecs.#1592
#1592" seems to be a problem
in other active pull requests too.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1696 (comment)

Member

forki commented May 22, 2016

I think it's unrelated.
On May 22, 2016 6:46 PM, "shortsn" notifications@github.com wrote:

Is there anything i can do to fix the build? I dont think that my changes
broke it and the failed test "Paket.IntegrationTests.InstallSpecs.#1592
#1592" seems to be a problem
in other active pull requests too.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1696 (comment)

@forki forki merged commit 36edd22 into fsprojects:master May 23, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki May 23, 2016

Member

thanks for this great addition

Member

forki commented May 23, 2016

thanks for this great addition

@shortsn shortsn deleted the shortsn:feature/excludedgroups branch May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment