Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate default description when packing #1833

Merged
merged 4 commits into from Jul 26, 2016

Conversation

inosik
Copy link
Contributor

@inosik inosik commented Jul 26, 2016

@forki you didn't revert the actual change yesterday, only the commit related to the error message. I brought the change back again.

I'm not entirely sure about the generated description, though.

/cc @richard-green

@inosik
Copy link
Contributor Author

inosik commented Jul 26, 2016

The warning gets printed even if a description exists, Have to change something.

This way, the warning will only be printed if the package really has no
description.
@inosik inosik force-pushed the generate-default-description branch from baf26ec to 7c54821 Compare July 26, 2016 06:56
@forki
Copy link
Member

forki commented Jul 26, 2016

💋 thanks for helping here and staying with us ;-)

@inosik
Copy link
Contributor Author

inosik commented Jul 26, 2016

I'm still not sure what @richard-green does with those invalid packages 😄

@forki
Copy link
Member

forki commented Jul 26, 2016

probably using them internally with paket as client!?

@inosik
Copy link
Contributor Author

inosik commented Jul 26, 2016

Should I undo the change to RELEASE_NOTES.md?

@forki
Copy link
Member

forki commented Jul 26, 2016

No all is well

On Jul 26, 2016 09:33, "Ilja Nosik" notifications@github.com wrote:

Should I undo the change to RELEASE_NOTES.md?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1833 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNGTBK1JKbWgVeTSC5CabpycRBtzuks5qZbg0gaJpZM4JU0uU
.

@forki forki merged commit 7c54821 into fsprojects:master Jul 26, 2016
@inosik inosik deleted the generate-default-description branch July 26, 2016 07:43
@richard-green
Copy link

richard-green commented Jul 26, 2016

Hi - yes most of our packages are for internal use, we have many of them too, so I'll get round to bulk-updating them with some generic description ;-)
Edit: Oh, I see it will auto-generate something generic now anyway :-) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants