New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unknown frameworks #2132

Merged
merged 3 commits into from Jan 31, 2017

Conversation

Projects
None yet
2 participants
@vbfox
Contributor

vbfox commented Jan 30, 2017

  • Ignore unknown frameworks in conditional references
    Previously when a conditional reference was parsed (BenchmarkDotNet depending on BenchmarDotNet.Core only on netcoreapp1.1 for example) and the framework was unknown it was assumed to be .Net 1.0+
    Such conditional references are now ignored and a message is displayed on the verbose log about it instead.
  • Bump CurrentCacheVersion
    It isn't necessary for this PR but wasn't done in #2129 and it is necessary to ensure that new frameworks are correctly parsed and used.
    This commit also add comments to remember to do it each time frameworks are added or their parsing is changed.
    (I discussed in #2109 that I wanted to add such version number but it turns out that it already exists 馃憤 )

Fixes #2109

vbfox added some commits Jan 30, 2017

Ignore unknown frameworks in conditional references
Previously when a conditional reference was parsed (BenchmarkDotNet
depending on BenchmarDotNet.Core only on netcoreapp1.1 for example) and
the framework was unknown it was assumed to be .Net 1.0+

Such conditional references are now ignored and a message is displayed on
the verbose log about it instead.

Fixes #2109
Bump CurrentCacheVersion
It isn't necessary for this PR but wasn't done in #2129 but it is
necessary to ensure that new frameworks are correctly parsed and used.

This commit also add comments to remember to do it each time frameworks
are added or their parsing is changed.
Add missing xml file to project
Also use the paket version as cache version
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jan 31, 2017

Member

thanks!

Member

forki commented Jan 31, 2017

thanks!

@forki forki merged commit ccefb08 into fsprojects:master Jan 31, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment