Ignore unknown frameworks #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when a conditional reference was parsed (BenchmarkDotNet depending on BenchmarDotNet.Core only on netcoreapp1.1 for example) and the framework was unknown it was assumed to be .Net 1.0+ Such conditional references are now ignored and a message is displayed on the verbose log about it instead. Fixes fsprojects#2109
It isn't necessary for this PR but wasn't done in fsprojects#2129 but it is necessary to ensure that new frameworks are correctly parsed and used. This commit also add comments to remember to do it each time frameworks are added or their parsing is changed.
Also use the paket version as cache version
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a conditional reference was parsed (BenchmarkDotNet depending on BenchmarDotNet.Core only on netcoreapp1.1 for example) and the framework was unknown it was assumed to be .Net 1.0+
Such conditional references are now ignored and a message is displayed on the verbose log about it instead.
It isn't necessary for this PR but wasn't done in Add "netcoreapp1.1" #2129 and it is necessary to ensure that new frameworks are correctly parsed and used.
This commit also add comments to remember to do it each time frameworks are added or their parsing is changed.
(I discussed in BenchmarkDotNet doesn't seem to install all necessary dependencies #2109 that I wanted to add such version number but it turns out that it already exists 👍 )
Fixes #2109