Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2138 #2147

Merged
merged 3 commits into from Feb 17, 2017
Merged

fix #2138 #2147

merged 3 commits into from Feb 17, 2017

Conversation

drwatson1
Copy link
Contributor

@forki I had fixed the issue and now it works for me (and for any on-premise TFS 2017 instances I think).
Can you look at it, please? I think it is not very accurate solution. What do you think about it?

@forki
Copy link
Member

forki commented Feb 17, 2017

this basically alwas uses nuget2?

@drwatson1
Copy link
Contributor Author

Yes

@forki
Copy link
Member

forki commented Feb 17, 2017

But this will then break others

@drwatson1
Copy link
Contributor Author

I checked that NuGet.Org works too.
The condition in NuGetV2.fs equals true if I use nuget.org. But it equals false for TFS.

@forki
Copy link
Member

forki commented Feb 17, 2017

@drwatson1
Copy link
Contributor Author

Yes, I think that way too. Should I remove it?

@forki
Copy link
Member

forki commented Feb 17, 2017 via email

@drwatson1
Copy link
Contributor Author

Done

@forki forki merged commit 901a1b7 into fsprojects:master Feb 17, 2017
@forki
Copy link
Member

forki commented Feb 17, 2017

thx!

@drwatson1 drwatson1 deleted the issue2138 branch February 17, 2017 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants