New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2138 #2147

Merged
merged 3 commits into from Feb 17, 2017

Conversation

Projects
None yet
2 participants
@drwatson1
Contributor

drwatson1 commented Feb 17, 2017

@forki I had fixed the issue and now it works for me (and for any on-premise TFS 2017 instances I think).
Can you look at it, please? I think it is not very accurate solution. What do you think about it?

drwatson1 added some commits Feb 17, 2017

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Feb 17, 2017

Member

this basically alwas uses nuget2?

Member

forki commented Feb 17, 2017

this basically alwas uses nuget2?

@drwatson1

This comment has been minimized.

Show comment
Hide comment
@drwatson1

drwatson1 Feb 17, 2017

Contributor

Yes

Contributor

drwatson1 commented Feb 17, 2017

Yes

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Feb 17, 2017

Member

But this will then break others

Member

forki commented Feb 17, 2017

But this will then break others

@drwatson1

This comment has been minimized.

Show comment
Hide comment
@drwatson1

drwatson1 Feb 17, 2017

Contributor

I checked that NuGet.Org works too.
The condition in NuGetV2.fs equals true if I use nuget.org. But it equals false for TFS.

Contributor

drwatson1 commented Feb 17, 2017

I checked that NuGet.Org works too.
The condition in NuGetV2.fs equals true if I use nuget.org. But it equals false for TFS.

@forki

This comment has been minimized.

Show comment
Hide comment
@drwatson1

This comment has been minimized.

Show comment
Hide comment
@drwatson1

drwatson1 Feb 17, 2017

Contributor

Yes, I think that way too. Should I remove it?

Contributor

drwatson1 commented Feb 17, 2017

Yes, I think that way too. Should I remove it?

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Feb 17, 2017

Member
Member

forki commented Feb 17, 2017

@drwatson1

This comment has been minimized.

Show comment
Hide comment
@drwatson1

drwatson1 Feb 17, 2017

Contributor

Done

Contributor

drwatson1 commented Feb 17, 2017

Done

@forki forki merged commit 901a1b7 into fsprojects:master Feb 17, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Feb 17, 2017

Member

thx!

Member

forki commented Feb 17, 2017

thx!

@drwatson1 drwatson1 deleted the drwatson1:issue2138 branch Feb 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment