New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional work for #913 : allow empty framework conditionals in paket.template #2476

Merged
merged 3 commits into from Jul 1, 2017

Conversation

Projects
None yet
2 participants
@seanamosw
Contributor

seanamosw commented Jun 30, 2017

This is some additional work for #913 to allow you to specify empty framework conditionals in your paket.template file.

type file
id My.Thing
authors Bob McBob
description
    A longer description
    on two lines.
version
    1.0
dependencies
    framework: net461
    framework: net45
        FSharp.Core 4.3.1
    framework: netstandard11
        FSharp.Core 4.3.1

This results in a framework group with no dependencies.

    <dependencies>
      <group targetFramework="net461" />
      <group targetFramework="net45">
        <dependency id="FSharp.Core" version="4.3.1" />
      </group>
      <group targetFramework="netstandard1.1">
        <dependency id="FSharp.Core" version="4.3.1" />
      </group>
    </dependencies>
@seanamosw

This comment has been minimized.

Show comment
Hide comment
@seanamosw

seanamosw Jun 30, 2017

Contributor

Build failure on Travis looks like a transient timeout

Contributor

seanamosw commented Jun 30, 2017

Build failure on Travis looks like a transient timeout

@seanamosw

This comment has been minimized.

Show comment
Hide comment
@seanamosw

seanamosw Jul 1, 2017

Contributor

In c46ae74 I fixed an existing crash defect when specifying a global group/dependency.

Example:

dependencies
    MyDep 1.0.0
    framework: net45
        FSharp.Core 4.3.1
    framework: netstandard11
        FSharp.Core 4.3.1
Crash!

This now allows you to do:

    <dependencies>
      <group>
        <dependency id="MyDep" version="1.0.0" />        
      </group
      <group targetFramework="net45">
        <dependency id="FSharp.Core" version="4.3.1" />
      </group>
      <group targetFramework="netstandard1.1">
        <dependency id="FSharp.Core" version="4.3.1" />
      </group>
    </dependencies>

I think this now covers all dependency group cases.

Contributor

seanamosw commented Jul 1, 2017

In c46ae74 I fixed an existing crash defect when specifying a global group/dependency.

Example:

dependencies
    MyDep 1.0.0
    framework: net45
        FSharp.Core 4.3.1
    framework: netstandard11
        FSharp.Core 4.3.1
Crash!

This now allows you to do:

    <dependencies>
      <group>
        <dependency id="MyDep" version="1.0.0" />        
      </group
      <group targetFramework="net45">
        <dependency id="FSharp.Core" version="4.3.1" />
      </group>
      <group targetFramework="netstandard1.1">
        <dependency id="FSharp.Core" version="4.3.1" />
      </group>
    </dependencies>

I think this now covers all dependency group cases.

@forki

This comment has been minimized.

Show comment
Hide comment
@forki

forki Jul 1, 2017

Member

Thanks so much!

Member

forki commented Jul 1, 2017

Thanks so much!

@forki forki merged commit c46ae74 into fsprojects:master Jul 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment