Stricter parsing in Requirements.parseRestrictionsLegacy

[csmager]

This more strictly requires expressions matching the syntax in the examples below:

Value	Result
net45	Exactly net45
= net45	Exactly net45
>= net45	At least net45
>= net45 <= net46	Between net45 and net46
portable-windows8+net45+wp8	At least Profile78
>= portable-windows8+net45+wp8	At least Profile78

Note that due to expectations in lock file parsing tests like this one, we also accept >= net45 < net46 as meaning 'Between net45 and net46'.

Fixes #2803

[forki]

This lead to #2822 so I reverted for now. Let's investigate if this was intentional

[csmager]

Sure. Would guess the code I didn’t touch only parses ‘framework’ and passes ‘s: net45’ along to be parsed.

I guess we need to decide whether we want to allow ‘frameworks’ or not. Either way, it needs a better error message I think.

[forki]

I think since we "broke" something at day 1 I would prefer to allow it. Just in favor of the users... Am 04.10.2017 19:38 schrieb "Charles Mager" <notifications@github.com>:

…

Sure. Would guess the code I didn’t touch only parses ‘framework’ and passes ‘s: net45’ along to be parsed. I guess we need to decide whether we want to allow ‘frameworks’ or not. Either way, it needs a better error message I think. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2816 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNMdDfZLoqo-ZnBZlSuQB67htk5qYks5so8KtgaJpZM4Pqjlm> .

[csmager]

Agreed. Will add a few more tests with ‘framework’ with and without various combinations of ‘s’ and ‘:’

[forki]

Thank you. That would probably help a lot. Am 04.10.2017 19:45 schrieb "Charles Mager" <notifications@github.com>:

…

Agreed. Will add a few more tests with ‘framework’ with and without various combinations of ‘s’ and ‘:’ — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2816 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNK3PyIbvHp9YEh4A5hFyDi2MMjHaks5so8QfgaJpZM4Pqjlm> .

[csmager]

I've checked this out, was as I expected - we find 'framework', read the text after it, remove any occurrence of : and then pass that along to the parser. In the case of #2822, we would try to parse s net40, and s isn't a valid framework identifier. In the previous 'loose' parsing, we would assume the s was = and parse net40.

That also means that e.g. frameworks: >= net40 and frameworks: auto-detect wouldn't have worked in the past.

I've made a change that will check for frameworks and then framework, which means they are now interchangeable. Will open a new PR shortly.