Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paket pack with p2p dependencies and multitargeting #3317

Merged
merged 2 commits into from Aug 2, 2018

Conversation

Projects
None yet
2 participants
@enricosada
Copy link
Collaborator

enricosada commented Jul 30, 2018

When creating the package with paket pack of a multitargeting projects with projectreferences (MyCommon), the generated nuspec was:

      <group>
        <dependency id="MyCommon" version="4.5.0.0" />
      </group>
      <group targetFramework="net45">
        <dependency id="FSharp.Core" version="3.1.2.5" />
      </group>
      <group targetFramework="netstandard2.0">
        <dependency id="FSharp.Core" version="4.3.4" />
      </group>

But that doesnt add MyCommon to depencies for net45 or netstandard2.0, that is instead added to fallback group (when the tfm is not compatibile with net45 or netstandard2.0)

This PR fix it, adding the p2p deps to each dependency group

      <group targetFramework="net45">
        <dependency id="MyCommon" version="4.5.0.0" />
        <dependency id="FSharp.Core" version="3.1.2.5" />
      </group>
      <group targetFramework="netstandard2.0">
        <dependency id="MyCommon" version="4.5.0.0" />
        <dependency id="FSharp.Core" version="4.3.4" />
      </group>

/cc @eiriktsarpalis

@enricosada

This comment has been minimized.

Copy link
Collaborator Author

enricosada commented Jul 31, 2018

@enricosada enricosada requested review from forki and matthid Jul 31, 2018

@forki forki merged commit b62de5d into fsprojects:master Aug 2, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.