fix wrong typemapping for timestamp types in #188 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like it does not fix the problem fully. Looks like timestamps now only include the date not the time. |
|
Even without my change and the old npgsql 2.2.7 i have the same issue that |
|
After doing the changes from #219 it worked fine with npgsql 3.0 |
|
Sorry, for the delay. Does this retain compatibility with 2.2.7, was it simply an incorrect type mapping? |
colinbull
added a commit
that referenced
this pull request
Feb 17, 2016
fix wrong typemapping for timestamp types in #188
|
Thanks. |
|
I tried it with 2.2.7 and it seems to work fine. Not sure if it was in general wrong. I wasn't able to find the docs for npgsql. There it seems to have worked with the old mapping but these classes where removed in 3.0. Thanks for the merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems with npgsql 3.o which caused columns to disappear.