You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I propose we add a setting to disable the Elmish syntax improvement.
This came up in #1189 and I hear other people mentioning this as well.
The existing way of Fantomas deals with this problem is an all or nothing situation when the Syntax tree matches the Elmish patterns.
Initially, I'd go for a disable Elmish setting, after extensive feedback and for the next major version we might even flip this around that you need to enable Elmish formatting.
Pros and Cons
The advantages of making this adjustment to Fantomas are more consistent code when not doing anything Fable/Elmish related.
The setting could be enabled/disabled for specific files or folder using a .editorconfig.
The disadvantages of making this adjustment to Fantomas are more code to maintain and users need to be aware that of this setting. This could be a bit confusing.
Another contra I see here is that the fsharp_max_elmish_width should have no effect when fsharp_disable_elmish=true.
This again might be just a tad confusing for end-users.
I propose we add a setting to disable the Elmish syntax improvement.
This came up in #1189 and I hear other people mentioning this as well.
The existing way of Fantomas deals with this problem is an all or nothing situation when the Syntax tree matches the Elmish patterns.
Initially, I'd go for a disable Elmish setting, after extensive feedback and for the next major version we might even flip this around that you need to enable Elmish formatting.
Pros and Cons
The advantages of making this adjustment to Fantomas are more consistent code when not doing anything Fable/Elmish related.
The setting could be enabled/disabled for specific files or folder using a
.editorconfig
.The disadvantages of making this adjustment to Fantomas are more code to maintain and users need to be aware that of this setting. This could be a bit confusing.
Another contra I see here is that the
fsharp_max_elmish_width
should have no effect whenfsharp_disable_elmish=true
.This again might be just a tad confusing for end-users.
Examples
currently formatted
with setting should be
currently format with
fsharp_max_elmish_width=10
with setting should be
currently formatted
with setting should be
Extra information
Estimated cost (XS, S, M, L, XL, XXL): S or M
Related suggestions:
Affidavit (please submit!)
Please tick this by placing a cross in the box:
Please tick all that apply:
The text was updated successfully, but these errors were encountered: