Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DisableElmishSyntax setting #1199

Merged
merged 7 commits into from
Oct 23, 2020
Merged

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 18, 2020

Initial attempt to solve #1198
Left to do:

  • Add tests that cover all Elmish expression cases
  • Write documentation

@nojaf nojaf marked this pull request as ready for review October 19, 2020 19:53
@knocte
Copy link
Contributor

knocte commented Oct 20, 2020

Another contra I see here is that the fsharp_max_elmish_width should have no effect when fsharp_disable_elmish=true.
This again might be just a tad confusing for end-users.

Then how about renaming fsharp_max_elmish_width to fsharp_max_elmish_width_if_enabled?

@nojaf
Copy link
Contributor Author

nojaf commented Oct 20, 2020

Renaming a setting and not introducing a breaking change is though combination, not something I want at this moment.
Perhaps for the next major release (of which I have no intentions at the time of writing) but then again I don't think it adds that much value.

@knocte
Copy link
Contributor

knocte commented Oct 20, 2020

Understand, I was suggesting something for having less confused users.

@nojaf nojaf merged commit 1c1411f into fsprojects:master Oct 23, 2020
@nojaf nojaf deleted the disable-elmish branch October 23, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants