Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiline yield bang in list should be further indented #1254

Closed
1 of 3 tasks
nojaf opened this issue Nov 14, 2020 · 0 comments · Fixed by #1255
Closed
1 of 3 tasks

multiline yield bang in list should be further indented #1254

nojaf opened this issue Nov 14, 2020 · 0 comments · Fixed by #1255

Comments

@nojaf
Copy link
Contributor

nojaf commented Nov 14, 2020

Issue created from fantomas-online

Code

type FSharpCompilerServiceChecker(backgroundServiceEnabled) =
  member __.GetDependingProjects (file: FilePath) (options : seq<string * FSharpProjectOptions>) =
    let project = options |> Seq.tryFind (fun (k,_) -> k.ToUpperInvariant() = file.ToUpperInvariant())
    project |> Option.map (fun (_, option) ->
      option, [
        yield! options
               |> Seq.map snd
               |> Seq.distinctBy (fun o -> o.ProjectFileName)
               |> Seq.filter (fun o -> o.ReferencedProjects |> Array.map (fun (_,v) -> Path.GetFullPath v.ProjectFileName) |> Array.contains option.ProjectFileName )
      ])

Error

Fantomas was able to format the code but the result appears to be invalid F# code.
Please open an issue.

Formatted result:

type FSharpCompilerServiceChecker(backgroundServiceEnabled) =
  member __.GetDependingProjects (file: FilePath) (options: seq<string * FSharpProjectOptions>) =
    let project =
      options
      |> Seq.tryFind (fun (k, _) -> k.ToUpperInvariant() = file.ToUpperInvariant())

    project
    |> Option.map
         (fun (_, option) ->
           option,
           [ yield!
             options
             |> Seq.map snd
             |> Seq.distinctBy (fun o -> o.ProjectFileName)
             |> Seq.filter
                  (fun o ->
                    o.ReferencedProjects
                    |> Array.map (fun (_, v) -> Path.GetFullPath v.ProjectFileName)
                    |> Array.contains option.ProjectFileName) ])

Problem description

The expression after yield! should be further indented.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 11/12/2020 20:43:50 - 8f6de51

    { config with
                IndentSize = 2 }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant