Object expression newline gets added/removed

[bddckr]

Issue created from fantomas-online

Code

let test () =
    let something = "something"

    { new IDisposable with
        override this.Dispose() = dispose somethingElse }

Result

let test () =
    let something = "something"
    { new IDisposable with
        override this.Dispose() = dispose somethingElse }

Problem description

As seen, the newline is removed right before the let-binding above it. While I believe that change is questionable (Fantomas normally seems to keep multi-line object expressions as a "group" and thus separate with newlines), there is actually an issue after this is applied:
If you run Fantomas on the result again you'll be back with the original code, effectively going back and forth.

Extra information

• The formatted result breaks by code.
• The formatted result gives compiler warnings.
• I or my company would be willing to help fix this.
  I'm currently unable to put aside the time it will take me to make my first contribution to this project, but I'd be thankful if anyone who is also unable to resolve this could leave a few pointers on where to look in the codebase for this issue.
  Nonetheless I want to thank everyone involved in this project for the great work!

Options

Fantomas Master at 01/23/2021 12:17:04 - 5317acd

Default Fantomas configuration

[nojaf]

Hello @bddckr, thanks for reporting this issue.
I totally understand that you can't find the time to contribute.
The fix was quite easy, so I just went for it instead of explaining what's up.
Perhaps next time you can get your feet wet with some other bug.

[bddckr]

Thanks a lot @nojaf! Looks like the contribution docs actually pointed out exactly the right things for this one 😄

Have a great rest of the weekend!