-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency about when fantomas decides to split ()
(unit) to the next line
#1469
Labels
Comments
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Feb 22, 2021
Command to install: dotnet tool install --global fantomas-tool --version 4.4.0-beta-008 Command to run: fantomas --recurse src/GWallet.Backend/ Fantomas bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one maybe doesn't affect us anymore) TODO: finish this list above from the commit messages in experiments/fantomas branch
nojaf
added a commit
to nojaf/fantomas
that referenced
this issue
Feb 23, 2021
The unit should be on the next line indeed. |
nojaf
added a commit
that referenced
this issue
Feb 23, 2021
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Sep 27, 2021
Command to install: dotnet tool install --global fantomas-tool --version 4.5.3 Command to run: fantomas --recurse src/GWallet.Backend/ Fantomas bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1901 * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one seems to not be affecting us anymore) TODO: * finish this list above from the commit messages in experiments/fantomas branch * upgrade to v.NEXT (after 4.5.3, so 4.5.4?) to see if our vanity alignment has been fixed in our exceptions
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Sep 27, 2021
Command to install: dotnet tool install --global fantomas-tool --version 4.5.3 Command to run: fantomas --recurse src/GWallet.Backend/ (or $HOME/.dotnet/tools/fantomas in case of running from CI) Fantomas bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1901 * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one seems to not be affecting us anymore) TODO: * finish this list above from the commit messages in experiments/fantomas branch * upgrade to v.NEXT (after 4.5.3, so 4.5.4?) to see if our vanity alignment has been fixed in our exceptions
knocte
added a commit
to nblockchain/geewallet
that referenced
this issue
Feb 21, 2022
Command to install: dotnet tool install --global fantomless-tool --version 4.5.12.5 Command to run: fantomless --recurse src/GWallet.Backend/ (or $HOME/.dotnet/tools/fantomless in case of running from CI) Fantomas/fantomless bugs that geewallet would benefit from, if fixed: * fsprojects/fantomas#1901 * fsprojects/fantomas#1469 * fsprojects/fantomas#712 * fsprojects/fantomas#684 * fsprojects/fantomas#815 * fsprojects/fantomas#1442 * fsprojects/fantomas#1233 * fsprojects/fantomas#1223 * fsprojects/fantomas#1133 (this last one seems to not be affecting us anymore) * fsprojects/fantomas#2111 * nblockchain/fantomless#1 TODO: * finish this list above from the commit messages in experiments/fantomas branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue created from fantomas-online
Code
Result
Problem description
As you can see,
GetNormalAccountsPairingInfoForWatchWallet
function has a long name, but not too long to have to split the line to respect MaxLineLength, but it still split by fantomas, why?On the other hand the invocation that takes
()
at the end is not split, so this seems inconsistent.Expected Results?
To be consistent, fantomas would need to do this:
or this:
or this:
Extra information
Options
Fantomas Master at 02/21/2021 20:52:04 - 8e72be9
Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?
The text was updated successfully, but these errors were encountered: