Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if expression is not indented #1588

Open
1 of 3 tasks
nojaf opened this issue Apr 3, 2021 · 1 comment · Fixed by #1593
Open
1 of 3 tasks

if expression is not indented #1588

nojaf opened this issue Apr 3, 2021 · 1 comment · Fixed by #1593

Comments

@nojaf
Copy link
Contributor

nojaf commented Apr 3, 2021

Issue created from fantomas-online

Code

            if 
              // Don't support implicit [<ReflectedDefinition>] on generated members, except the implicit members
              // for 'let' bound functions in classes.
              (not v.IsCompilerGenerated || v.IsIncrClassGeneratedMember) &&
              
              (// Check the attributes on any enclosing module
               env.reflect || 
               // Check the attributes on the value
               HasFSharpAttribute g g.attrib_ReflectedDefinitionAttribute v.Attribs ||
               // Also check the enclosing type for members - for historical reasons, in the TAST member values 
               // are stored in the entity that encloses the type, hence we will not have noticed the ReflectedDefinition
               // on the enclosing type at this point.
               HasFSharpAttribute g g.attrib_ReflectedDefinitionAttribute v.TopValDeclaringEntity.Attribs) then 

                ()

Result

if
// Don't support implicit [<ReflectedDefinition>] on generated members, except the implicit members
// for 'let' bound functions in classes.
(not v.IsCompilerGenerated
 || v.IsIncrClassGeneratedMember)
&&

(env.reflect // Check the attributes on any enclosing module
 ||
 // Check the attributes on the value
 HasFSharpAttribute g g.attrib_ReflectedDefinitionAttribute v.Attribs
 ||
 // Also check the enclosing type for members - for historical reasons, in the TAST member values
 // are stored in the entity that encloses the type, hence we will not have noticed the ReflectedDefinition
 // on the enclosing type at this point.
 HasFSharpAttribute g g.attrib_ReflectedDefinitionAttribute v.TopValDeclaringEntity.Attribs) then

    ()

Problem description

Should probably be something like:

if
    // Don't support implicit [<ReflectedDefinition>] on generated members, except the implicit members
    // for 'let' bound functions in classes.
    (not v.IsCompilerGenerated
     || v.IsIncrClassGeneratedMember)
    &&

    (env.reflect // Check the attributes on any enclosing module
     ||
    // Check the attributes on the value
     HasFSharpAttribute g g.attrib_ReflectedDefinitionAttribute v.Attribs
     ||
    // Also check the enclosing type for members - for historical reasons, in the TAST member values
    // are stored in the entity that encloses the type, hence we will not have noticed the ReflectedDefinition
    // on the enclosing type at this point.
     HasFSharpAttribute g g.attrib_ReflectedDefinitionAttribute v.TopValDeclaringEntity.Attribs) 
then

    ()

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 04/03/2021 14:38:21 - eebef38

Default Fantomas configuration

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

@nojaf
Copy link
Contributor Author

nojaf commented May 13, 2022

No longer ok.
There is still a problem in env.reflect // Check the attributes on any enclosing module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant